Merge pull request #74 from php-http/cs

fix cs

Author: dbu

.github/workflows/checks.yml

@@ -18,13 +18,3 @@ jobs:
       - name: Composer normalize
         uses: docker://ergebnis/composer-normalize-action
 
-  roave-bc-check:
-    name: Roave BC Check
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Roave BC Check
-        uses: docker://nyholm/roave-bc-check-ga

src/Client.php

@@ -59,9 +59,6 @@ public function __construct($config1 = [], $config2 = null, array $config = [])
         $this->config = $this->configure($config2 ?: $config);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function sendRequest(RequestInterface $request): ResponseInterface
     {
         $remote = $this->config['remote_socket'];
@@ -100,9 +97,9 @@ public function sendRequest(RequestInterface $request): ResponseInterface
      * @param string           $remote  Entrypoint for the connection
      * @param bool             $useSsl  Whether to use ssl or not
      *
-     * @throws ConnectionException|SSLConnectionException When the connection fail
-     *
      * @return resource Socket resource
+     *
+     * @throws ConnectionException|SSLConnectionException When the connection fail
      */
     protected function createSocket(RequestInterface $request, string $remote, bool $useSsl)
     {
@@ -174,9 +171,9 @@ protected function configure(array $config = [])
     /**
      * Return remote socket from the request.
      *
-     * @throws InvalidRequestException When no remote can be determined from the request
-     *
      * @return string
+     *
+     * @throws InvalidRequestException When no remote can be determined from the request
      */
     private function determineRemoteFromRequest(RequestInterface $request)
     {

src/Exception/NetworkException.php

@@ -12,7 +12,7 @@ class NetworkException extends \RuntimeException implements NetworkExceptionInte
      */
     private $request;
 
-    public function __construct(string $message, RequestInterface $request, \Exception $previous = null)
+    public function __construct(string $message, RequestInterface $request, ?\Exception $previous = null)
     {
         $this->request = $request;
 

src/RequestWriter.php

@@ -123,6 +123,7 @@ private function fwrite($stream, string $bytes)
             // The write worked or failed explicitly. This value is fine to return.
             return $result;
         }
+
         // We performed a 0-length write, were told that the stream was writable, and
         // then immediately performed another 0-length write. Conclude that the pipe
         // is broken and return `false`.

src/Stream.php

@@ -61,9 +61,6 @@ public function __construct(RequestInterface $request, $socket, ?int $size = nul
         $this->request = $request;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function __toString()
     {
         try {
@@ -73,9 +70,6 @@ public function __toString()
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function close()
     {
         if ($this->isDetached || null === $this->socket) {
@@ -84,9 +78,6 @@ public function close()
         fclose($this->socket);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function detach()
     {
         if ($this->isDetached) {
@@ -100,18 +91,13 @@ public function detach()
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @return int<0, max>|null
      */
     public function getSize()
     {
         return $this->size;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function tell()
     {
         if ($this->isDetached || null === $this->socket) {
@@ -125,9 +111,6 @@ public function tell()
         return $tell;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function eof()
     {
         if ($this->isDetached || null === $this->socket) {
@@ -137,17 +120,12 @@ public function eof()
         return feof($this->socket);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function isSeekable()
     {
         return false;
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @return void
      */
     public function seek($offset, $whence = SEEK_SET)
@@ -156,42 +134,29 @@ public function seek($offset, $whence = SEEK_SET)
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @return void
      */
     public function rewind()
     {
         throw new StreamException('This stream is not seekable');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function isWritable()
     {
         return false;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function write($string)
     {
         throw new StreamException('This stream is not writable');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function isReadable()
     {
         return true;
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @param int<0, max> $length
      */
     public function read($length)
@@ -232,9 +197,6 @@ public function read($length)
         return $read;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getContents()
     {
         if ($this->isDetached || null === $this->socket) {
@@ -261,9 +223,6 @@ public function getContents()
         return $contents;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getMetadata($key = null)
     {
         if ($this->isDetached || null === $this->socket) {

tests/SocketHttpAdapterTest.php

@@ -8,9 +8,6 @@
 
 class SocketHttpAdapterTest extends HttpClientTest
 {
-    /**
-     * {@inheritdoc}
-     */
     protected function createHttpAdapter(): ClientInterface
     {
         return new SocketHttpClient();

tests/server/tcp-bugous-server.php

@@ -6,4 +6,4 @@
 $client = stream_socket_accept($socketServer);
 
 fclose($client);
-\Http\Client\Socket\Tests\Semaphore::release();
+Http\Client\Socket\Tests\Semaphore::release();

tests/server/tcp-server.php

@@ -16,4 +16,4 @@
 while (!@feof($client)) {
     @fread($client, 1000);
 }
-\Http\Client\Socket\Tests\Semaphore::release();
+Http\Client\Socket\Tests\Semaphore::release();

tests/server/tcp-ssl-server-client.php

@@ -46,4 +46,4 @@
 while (!@feof($client)) {
     @fread($client, 1000);
 }
-\Http\Client\Socket\Tests\Semaphore::release();
+Http\Client\Socket\Tests\Semaphore::release();

tests/server/tcp-ssl-server.php

@@ -35,4 +35,4 @@
     @fread($client, 1000);
 }
 
-\Http\Client\Socket\Tests\Semaphore::release();
+Http\Client\Socket\Tests\Semaphore::release();

tests/server/unix-domain-server.php

@@ -22,4 +22,4 @@
 }
 
 unlink(__DIR__.'/server.sock');
-\Http\Client\Socket\Tests\Semaphore::release();
+Http\Client\Socket\Tests\Semaphore::release();