Sending Content-Length: 0 is optional for TRACE (#33)

kelunik · Nyholm · commit ca59f01c4ced · 2017-07-10T22:30:29.000+02:00
* Sending Content-Length: 0 is optional for TRACE

* Don't make any useless assertions
diff --git a/src/HttpBaseTest.php b/src/HttpBaseTest.php
@@ -270,6 +270,10 @@ protected function assertRequest(
 
             $name = strtoupper(str_replace('-', '_', 'http-'.$name));
 
+            if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) {
+                continue;
+            }
+
             $this->assertArrayHasKey($name, $request['SERVER']);
             $this->assertSame($value, $request['SERVER'][$name], "Failed asserting value for {$name}.");
         }

Original file line number	Diff line number	Diff line change
`@@ -270,6 +270,10 @@ protected function assertRequest(`
`270`	`270`
`271`	`271`	`$name = strtoupper(str_replace('-', '_', 'http-'.$name));`
`272`	`272`
	`273`	`+ if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) {`
	`274`	`+ continue;`
	`275`	`+ }`
	`276`	`+`
`273`	`277`	`$this->assertArrayHasKey($name, $request['SERVER']);`
`274`	`278`	`$this->assertSame($value, $request['SERVER'][$name], "Failed asserting value for {$name}.");`
`275`	`279`	`}`