fix#91: Change clientCache so it doesn't force no-cache & max-age response directives

nunoplopes · web-flow · commit 43031b09dda3 · 2025-02-11T17:22:14.000Z
diff --git a/src/CachePlugin.php b/src/CachePlugin.php
@@ -95,11 +95,7 @@ public function __construct(CacheItemPoolInterface $pool, StreamFactoryInterface
     public static function clientCache(CacheItemPoolInterface $pool, StreamFactoryInterface $streamFactory, array $config = [])
     {
         // Allow caching of private requests
-        if (\array_key_exists('respect_response_cache_directives', $config)) {
-            $config['respect_response_cache_directives'][] = 'no-cache';
-            $config['respect_response_cache_directives'][] = 'max-age';
-            $config['respect_response_cache_directives'] = array_unique($config['respect_response_cache_directives']);
-        } else {
+        if (!\array_key_exists('respect_response_cache_directives', $config)) {
             $config['respect_response_cache_directives'] = ['no-cache', 'max-age'];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -95,11 +95,7 @@ public function __construct(CacheItemPoolInterface $pool, StreamFactoryInterface`
`95`	`95`	`public static function clientCache(CacheItemPoolInterface $pool, StreamFactoryInterface $streamFactory, array $config = [])`
`96`	`96`	`{`
`97`	`97`	`// Allow caching of private requests`
`98`		`- if (\array_key_exists('respect_response_cache_directives', $config)) {`
`99`		`- $config['respect_response_cache_directives'][] = 'no-cache';`
`100`		`- $config['respect_response_cache_directives'][] = 'max-age';`
`101`		`- $config['respect_response_cache_directives'] = array_unique($config['respect_response_cache_directives']);`
`102`		`- } else {`
	`98`	`+ if (!\array_key_exists('respect_response_cache_directives', $config)) {`
`103`	`99`	`$config['respect_response_cache_directives'] = ['no-cache', 'max-age'];`
`104`	`100`	`}`
`105`	`101`