Skip to content

Commit 37581cb

Browse files
committed
added changelog and fixed type issues
1 parent 9c85f7d commit 37581cb

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# Change Log
2+
3+
All notable changes to this project will be documented in this file.
4+
5+
The format is based on [Keep a Changelog](http://keepachangelog.com/)
6+
and this project adheres to [Semantic Versioning](http://semver.org/).
7+
8+
Previous releases are documented in [github releases](https://github.com/oscarotero/Gettext/releases)
9+
10+
## [1.0.0] - Unreleased
11+
12+
First version

src/PhpFunctionsScanner.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function __construct(array $validFunctions = null, Parser $parser = null)
1818
$this->parser = $parser ?: (new ParserFactory())->create(ParserFactory::PREFER_PHP7);
1919
}
2020

21-
public function scan(string $code, string $filename = null): array
21+
public function scan(string $code, string $filename): array
2222
{
2323
$ast = $this->parser->parse($code);
2424

src/PhpNodeVisitor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class PhpNodeVisitor implements NodeVisitor
1414
protected $filename;
1515
protected $functions = [];
1616

17-
public function __construct(string $filename = null, array $validFunctions = null)
17+
public function __construct(string $filename, array $validFunctions = null)
1818
{
1919
$this->filename = $filename;
2020
$this->validFunctions = $validFunctions;

0 commit comments

Comments
 (0)