Skip to content

php-enqueue/amqp-ext not support ext-amqp 2.0 #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jafaripur opened this issue Aug 29, 2023 · 8 comments · Fixed by #1320
Closed

php-enqueue/amqp-ext not support ext-amqp 2.0 #1313

jafaripur opened this issue Aug 29, 2023 · 8 comments · Fixed by #1320

Comments

@jafaripur
Copy link

amqp ext upgraded to version 2.0 and fix some error for PHP 8.2 and can not use the latest version bacause of php-enqueue/amqp-ext add requirement in composer.json "ext-amqp": "^1.9.3".
@makasim
Copy link
Member

makasim commented Aug 31, 2023

PR is welcome

@jafaripur
Copy link
Author

Pull request sent

@AlexOstrovsky
Copy link

any update on this?

@makasim
Copy link
Member

makasim commented Nov 1, 2023

php-enqueue/amqp-ext#2 (comment)

@AlexOstrovsky
Copy link

@makasim yeah I saw that but what is needed to get this to the main library?

@makasim
Copy link
Member

makasim commented Nov 2, 2023 •
edited
Loading

A PR has to be opened in this repo (https://github.com/php-enqueue/enqueue-dev), not amqp-ext (https://github.com/php-enqueue/amqp-ext)

Once merged, it will appear in amqp-ext.

@AlexOstrovsky AlexOstrovsky mentioned this issue Nov 3, 2023
Merged
@AlexOstrovsky
Copy link

@makasim I opened PR #1320 to this repo

@AlexOstrovsky
Copy link

@makasim when sould we expect new release so we can start using this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update ext-amqp to use v2 AlexOstrovsky/enqueue-dev
3 participants
@makasim @jafaripur @AlexOstrovsky