Skip to content

Commit 7dbe0a4

Browse files
committed
refactor(namespaces): renamed \Null to \NoEffect outside pkg/null too
'null' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
1 parent af486e5 commit 7dbe0a4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+85
-85
lines changed

docs/transport/null.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $ composer require enqueue/null
2525

2626
```php
2727
<?php
28-
use Enqueue\Null\NullConnectionFactory;
28+
use Enqueue\NoEffect\NullConnectionFactory;
2929

3030
$connectionFactory = new NullConnectionFactory();
3131

pkg/amqp-bunny/Tests/AmqpConsumerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Bunny\Message;
88
use Enqueue\AmqpBunny\AmqpConsumer;
99
use Enqueue\AmqpBunny\AmqpContext;
10-
use Enqueue\Null\NullMessage;
10+
use Enqueue\NoEffect\NullMessage;
1111
use Enqueue\Test\ClassExtensionTrait;
1212
use Enqueue\Test\WriteAttributeTrait;
1313
use Interop\Amqp\Impl\AmqpMessage;

pkg/amqp-ext/Tests/AmqpContextTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
use Enqueue\AmqpExt\AmqpContext;
77
use Enqueue\AmqpExt\AmqpProducer;
88
use Enqueue\AmqpExt\AmqpSubscriptionConsumer;
9-
use Enqueue\Null\NullQueue;
10-
use Enqueue\Null\NullTopic;
9+
use Enqueue\NoEffect\NullQueue;
10+
use Enqueue\NoEffect\NullTopic;
1111
use Enqueue\Test\ClassExtensionTrait;
1212
use Enqueue\Test\ReadAttributeTrait;
1313
use Interop\Amqp\Impl\AmqpMessage;
@@ -124,7 +124,7 @@ public function testShouldThrowIfNotAmqpQueueGivenOnCreateConsumerCall()
124124
$context = new AmqpContext($this->createExtChannelMock());
125125

126126
$this->expectException(InvalidDestinationException::class);
127-
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\Null\NullQueue.');
127+
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpQueue but got Enqueue\NoEffect\NullQueue.');
128128
$context->createConsumer(new NullQueue('aName'));
129129
}
130130

@@ -133,7 +133,7 @@ public function testShouldThrowIfNotAmqpTopicGivenOnCreateConsumerCall()
133133
$context = new AmqpContext($this->createExtChannelMock());
134134

135135
$this->expectException(InvalidDestinationException::class);
136-
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\Null\NullTopic.');
136+
$this->expectExceptionMessage('The destination must be an instance of Interop\Amqp\AmqpTopic but got Enqueue\NoEffect\NullTopic.');
137137
$context->createConsumer(new NullTopic('aName'));
138138
}
139139

pkg/amqp-lib/Tests/AmqpConsumerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Enqueue\AmqpLib\AmqpConsumer;
66
use Enqueue\AmqpLib\AmqpContext;
7-
use Enqueue\Null\NullMessage;
7+
use Enqueue\NoEffect\NullMessage;
88
use Enqueue\Test\ClassExtensionTrait;
99
use Enqueue\Test\WriteAttributeTrait;
1010
use Interop\Amqp\Impl\AmqpMessage;

pkg/async-command/Tests/Functional/UseCasesTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
use Enqueue\AsyncCommand\RunCommand;
77
use Enqueue\AsyncCommand\RunCommandProcessor;
88
use Enqueue\Consumption\Result;
9-
use Enqueue\Null\NullContext;
10-
use Enqueue\Null\NullMessage;
9+
use Enqueue\NoEffect\NullContext;
10+
use Enqueue\NoEffect\NullMessage;
1111
use Interop\Queue\Message;
1212
use PHPUnit\Framework\TestCase;
1313

pkg/async-event-dispatcher/Tests/AsyncListenerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
use Enqueue\AsyncEventDispatcher\AsyncListener;
66
use Enqueue\AsyncEventDispatcher\EventTransformer;
77
use Enqueue\AsyncEventDispatcher\Registry;
8-
use Enqueue\Null\NullMessage;
9-
use Enqueue\Null\NullQueue;
8+
use Enqueue\NoEffect\NullMessage;
9+
use Enqueue\NoEffect\NullQueue;
1010
use Enqueue\Test\ClassExtensionTrait;
1111
use Enqueue\Test\ReadAttributeTrait;
1212
use Interop\Queue\Context;

pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
use Enqueue\AsyncEventDispatcher\EventTransformer;
88
use Enqueue\AsyncEventDispatcher\Registry;
99
use Enqueue\Consumption\Result;
10-
use Enqueue\Null\NullContext;
11-
use Enqueue\Null\NullMessage;
10+
use Enqueue\NoEffect\NullContext;
11+
use Enqueue\NoEffect\NullMessage;
1212
use Enqueue\Test\ClassExtensionTrait;
1313
use Interop\Queue\Processor;
1414
use PHPUnit\Framework\MockObject\MockObject;

pkg/async-event-dispatcher/Tests/PhpSerializerEventTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Enqueue\AsyncEventDispatcher\EventTransformer;
66
use Enqueue\AsyncEventDispatcher\PhpSerializerEventTransformer;
7-
use Enqueue\Null\NullMessage;
7+
use Enqueue\NoEffect\NullMessage;
88
use Enqueue\Test\ClassExtensionTrait;
99
use Interop\Queue\Context;
1010
use Interop\Queue\Message;

pkg/enqueue-bundle/Tests/Functional/Events/AsyncProcessorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
use Enqueue\Bundle\Tests\Functional\App\TestAsyncListener;
88
use Enqueue\Bundle\Tests\Functional\App\TestAsyncSubscriber;
99
use Enqueue\Bundle\Tests\Functional\WebTestCase;
10-
use Enqueue\Null\NullContext;
11-
use Enqueue\Null\NullMessage;
10+
use Enqueue\NoEffect\NullContext;
11+
use Enqueue\NoEffect\NullMessage;
1212
use Enqueue\Util\JSON;
1313
use Interop\Queue\Processor;
1414
use Symfony\Component\EventDispatcher\GenericEvent;

pkg/enqueue/Resources.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use Enqueue\Gearman\GearmanConnectionFactory;
1111
use Enqueue\Gps\GpsConnectionFactory;
1212
use Enqueue\Mongodb\MongodbConnectionFactory;
13-
use Enqueue\Null\NullConnectionFactory;
13+
use Enqueue\NoEffect\NullConnectionFactory;
1414
use Enqueue\Pheanstalk\PheanstalkConnectionFactory;
1515
use Enqueue\RdKafka\RdKafkaConnectionFactory;
1616
use Enqueue\Redis\RedisConnectionFactory;

0 commit comments

Comments
 (0)