Skip to content

Commit 9afd224

Browse files
authored
Merge pull request #119 from Alltricks/master
`voku\arrayy` in dev requirement
2 parents a6490ac + be08892 commit 9afd224

File tree

5 files changed

+22
-33
lines changed

5 files changed

+22
-33
lines changed

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@
2626
}
2727
],
2828
"require": {
29-
"php": ">=7.0.0",
29+
"php": "~8",
3030
"ext-json": "*",
31-
"ext-simplexml": "*",
32-
"voku/arrayy": "~7.1"
31+
"ext-simplexml": "*"
3332
},
3433
"require-dev": {
3534
"php-edifact/edifact-mapping": "dev-master",
36-
"phpunit/phpunit": "~6.0"
35+
"phpunit/phpunit": "~9.0",
36+
"voku/arrayy": "~7.1"
3737
},
3838
"autoload": {
3939
"psr-4": {

src/EDI/Interpreter.php

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
namespace EDI;
66

7-
use Arrayy\Arrayy;
8-
97
/**
108
* EDIFACT Messages Interpreter
119
* (c) 2018 Stefano Sabatini
@@ -264,13 +262,13 @@ public function getJson(bool $pretty = false)
264262
}
265263

266264
/**
267-
* Get result as Arrayy Object.
265+
* Get EDI groups.
268266
*
269-
* @return Arrayy<mixed,mixed>
267+
* @return array
270268
*/
271-
public function getArrayy()
269+
public function getEdiGroups()
272270
{
273-
return new Arrayy($this->ediGroups);
271+
return $this->ediGroups;
274272
}
275273

276274
/**
@@ -319,16 +317,6 @@ public function getJsonServiceSegments(bool $pretty = false)
319317
return \json_encode($this->serviceSeg);
320318
}
321319

322-
/**
323-
* Get service segments as Arrayy Object.
324-
*
325-
* @return Arrayy<mixed,mixed>
326-
*/
327-
public function getArrayyServiceSegments()
328-
{
329-
return new Arrayy($this->serviceSeg);
330-
}
331-
332320
/**
333321
* Split multiple messages
334322
*

tests/EDITest/AnalyserTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ final class AnalyserTest extends TestCase
2222
*/
2323
protected $mapping;
2424

25-
protected function setUp()
25+
protected function setUp(): void
2626
{
2727
$this->analyser = new Analyser();
2828
$this->mapping = new MappingProvider('D07A');

tests/EDITest/InterpreterTest.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace EDITest;
44

5+
use EDI\Parser;
56
use EDI\Analyser;
7+
use Arrayy\Arrayy;
68
use EDI\Interpreter;
7-
use EDI\Parser;
89

910
/**
1011
* @internal
@@ -146,16 +147,16 @@ public function testOrderError()
146147

147148
static::assertCount(2, $interpreter->getMessages());
148149

149-
static::assertContains('"messageHeader"', $interpreter->getJson(true));
150-
static::assertContains('"interchangeHeader"', $interpreter->getJsonServiceSegments(true));
150+
$this->assertStringContainsString('"messageHeader"', $interpreter->getJson(true));
151+
static::assertStringContainsString('"interchangeHeader"', $interpreter->getJsonServiceSegments(true));
151152

152-
$arrayy = $interpreter->getArrayy();
153+
$arrayy = new Arrayy($interpreter->getEdiGroups());
153154
static::assertSame(
154155
'Butter 40x250g Alu',
155156
$arrayy->get('0.SG25.0.itemDescription.itemDescription.itemDescription')
156157
);
157158

158-
$arrayy = $interpreter->getArrayyServiceSegments();
159+
$arrayy = new Arrayy($interpreter->getServiceSegments());
159160
static::assertCount(
160161
14,
161162
$arrayy->get('interchangeHeader')
@@ -181,16 +182,16 @@ public function testOrderOk()
181182

182183
static::assertCount(2, $interpreter->getMessages());
183184

184-
static::assertContains('"messageHeader"', $interpreter->getJson(true));
185-
static::assertContains('"interchangeHeader"', $interpreter->getJsonServiceSegments(true));
185+
static::assertStringContainsString('"messageHeader"', $interpreter->getJson(true));
186+
static::assertStringContainsString('"interchangeHeader"', $interpreter->getJsonServiceSegments(true));
186187

187-
$arrayy = $interpreter->getArrayy();
188+
$arrayy = new Arrayy($interpreter->getEdiGroups());
188189
static::assertSame(
189190
'Butter 40x250g Alu',
190191
$arrayy->get('0.SG25.0.itemDescription.itemDescription.itemDescription')
191192
);
192193

193-
$arrayy = $interpreter->getArrayyServiceSegments();
194+
$arrayy = new Arrayy($interpreter->getServiceSegments());
194195
static::assertCount(
195196
14,
196197
$arrayy->get('interchangeHeader')

tests/EDITest/ParserTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ public function testFileOk()
104104
static::assertSame([], $errors);
105105

106106
$data = \json_encode((new Parser($string))->get());
107-
static::assertContains('Sup 1:10', $data);
108-
static::assertNotContains('Konzentrat:o', $data);
109-
static::assertContains('"Rindfleischsuppe Konzentrat","o', $data);
107+
static::assertStringContainsString('Sup 1:10', $data);
108+
static::assertStringNotContainsString('Konzentrat:o', $data);
109+
static::assertStringContainsString('"Rindfleischsuppe Konzentrat","o', $data);
110110
}
111111

112112
public function testFileError()

0 commit comments

Comments
 (0)