Fix sqrt of -INF returning -INF instead of NAN

rtheunissen · rtheunissen · commit b8a9d86a5656 · 2019-02-11T12:48:48.000-08:00
diff --git a/src/math.c b/src/math.c
@@ -220,13 +220,13 @@ void php_decimal_sqrt(mpd_t *res, const mpd_t *op1, zend_long prec)
 {
     uint32_t status = 0;
 
-    if (UNEXPECTED(mpd_isspecial(op1))) {
-        mpd_qcopy(res, op1, &status);
+    if (mpd_isnegative(op1)) {
+        php_decimal_set_nan(res);
         return;
     }
 
-    if (mpd_isnegative(op1)) {
-        php_decimal_set_nan(res);
+    if (UNEXPECTED(mpd_isspecial(op1))) {
+        mpd_qcopy(res, op1, &status);
         return;
     }
 
diff --git a/tests/Decimal/methods/sqrt.phpt b/tests/Decimal/methods/sqrt.phpt
@@ -28,7 +28,7 @@ $tests = [
 
     [Decimal::valueOf( "NAN"),       "NAN",      Decimal::DEFAULT_PRECISION],
     [Decimal::valueOf( "INF"),       "INF",      Decimal::DEFAULT_PRECISION],
-    [Decimal::valueOf("-INF"),      "-INF",      Decimal::DEFAULT_PRECISION],
+    [Decimal::valueOf("-INF"),       "NAN",      Decimal::DEFAULT_PRECISION],
 ];
 
 foreach ($tests as $test) {

Original file line number	Diff line number	Diff line change
`@@ -220,13 +220,13 @@ void php_decimal_sqrt(mpd_t res, const mpd_t op1, zend_long prec)`
`220`	`220`	`{`
`221`	`221`	`uint32_t status = 0;`
`222`	`222`
`223`		`- if (UNEXPECTED(mpd_isspecial(op1))) {`
`224`		`- mpd_qcopy(res, op1, &status);`
	`223`	`+ if (mpd_isnegative(op1)) {`
	`224`	`+ php_decimal_set_nan(res);`
`225`	`225`	`return;`
`226`	`226`	`}`
`227`	`227`
`228`		`- if (mpd_isnegative(op1)) {`
`229`		`- php_decimal_set_nan(res);`
	`228`	`+ if (UNEXPECTED(mpd_isspecial(op1))) {`
	`229`	`+ mpd_qcopy(res, op1, &status);`
`230`	`230`	`return;`
`231`	`231`	`}`
`232`	`232`