Skip to content

Commit 3437675

Browse files
committed
Merge branch 'feature-error-handling-middlware'
2 parents 8cad202 + 6695ad9 commit 3437675

File tree

4 files changed

+31
-36
lines changed

4 files changed

+31
-36
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"php": "^7.0",
1414
"api-clients/middleware": "^2.0",
1515
"api-clients/resource": "^3.0",
16-
"api-clients/rx": "dev-master",
16+
"api-clients/rx": "^2.0",
1717
"api-clients/service": "dev-master",
1818
"clue/block-react": "^1.1",
1919
"clue/buzz-react": "^1.1",

composer.lock

Lines changed: 21 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/StreamingResponse.php

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,17 @@ public function getResponse(): ResponseInterface
3434

3535
/**
3636
* @param ObserverInterface $observer
37-
* @param SchedulerInterface $scheduler
3837
* @return DisposableInterface
38+
* @ignoreCodeCoverage
3939
*/
40-
public function subscribe(ObserverInterface $observer, $scheduler = null): DisposableInterface
40+
// @codingStandardsIgnoreStart
41+
protected function _subscribe(ObserverInterface $observer): DisposableInterface
4142
{
43+
// @codingStandardsIgnoreEnd
4244
$body = $this->response->getBody();
43-
$body->on('data', function (string $data) use ($observer) {
44-
$observer->onNext($data);
45-
});
46-
$body->on('end', function () use ($observer) {
47-
$observer->onCompleted();
48-
});
49-
$body->on('error', function ($error) use ($observer) {
50-
$observer->onError($error);
51-
});
45+
$body->on('data', [$observer, 'onNext']);
46+
$body->on('error', [$observer, 'onError']);
47+
$body->on('end', [$observer, 'onCompleted']);
5248

5349
return new EmptyDisposable();
5450
}

tests/StreamingResponseTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public function testResponse()
2727
$psr7Response = new Response(200, [], new ReadableBodyStream($stream));
2828
$response = new StreamingResponse($psr7Response);
2929
self::assertSame($psr7Response, $response->getResponse());
30-
$result = await(Promise::fromObservable(Promise::toObservable(resolve($response))->switchLatest()), $loop);
30+
$result = await(Promise::fromObservable(Promise::toObservable(resolve($response))->switch()), $loop);
3131
self::assertSame($string, $result);
3232
}
3333

@@ -44,6 +44,6 @@ public function testResponseError()
4444
});
4545
$psr7Response = new Response(200, [], new ReadableBodyStream($stream));
4646
$response = new StreamingResponse($psr7Response);
47-
await(Promise::fromObservable(Promise::toObservable(resolve($response))->switchLatest()), $loop);
47+
await(Promise::fromObservable(Promise::toObservable(resolve($response))->switch()), $loop);
4848
}
4949
}

0 commit comments

Comments
 (0)