Merge branch 'development' into master

Author: merl111

Phantasma.API/NexusAPI.cs

@@ -1765,15 +1765,14 @@ public IAPIResult GetPlatforms()
             foreach (var platform in platforms)
             {
                 var info = Nexus.GetPlatformInfo(Nexus.RootStorage, platform);
-
-
                 var entry = new PlatformResult();
                 entry.platform = platform;
                 entry.interop = info.InteropAddresses.Select(x => new InteropResult()
                 {
                     local = x.LocalAddress.Text,
                     external = x.ExternalAddress
-                }).ToArray();
+                }).Reverse().ToArray();
+                //TODO reverse array for now, only the last item is valid for now.
                 entry.chain = DomainExtensions.GetChainAddress(info).Text;
                 entry.fuel = info.Symbol;
                 entry.tokens = symbols.Where(x => Nexus.HasTokenPlatformHash(x, platform, Nexus.RootStorage)).ToArray();

Phantasma.Blockchain/BlockOracle.cs

@@ -22,7 +22,6 @@ public override T Read<T>(Timestamp time, string url)
         {
             T content = null;
 
-
             foreach(KeyValuePair<string, OracleEntry> entry in _entries)
             {
                 var tag = url.Substring(url.IndexOf("//")+2);

Phantasma.Blockchain/Chain.cs

@@ -197,18 +197,18 @@ public StorageChangeSetContext ProcessTransactions(Block block, IEnumerable<Tran
                 txIndex++;
             }
 
-            // TODO avoid fetching this every time
-            var expectedProtocol = Nexus.GetGovernanceValue(Nexus.RootStorage, Nexus.NexusProtocolVersionTag);
-            if (block.Protocol != expectedProtocol)
+            // Only check protocol version if block is created on this node, no need to check if it's a non validator node.
+            if (allowModify)
             {
-                throw new BlockGenerationException($"invalid protocol number {block.Protocol}, expected protocol {expectedProtocol}");
-            }
+                var expectedProtocol = Nexus.GetGovernanceValue(Nexus.RootStorage, Nexus.NexusProtocolVersionTag);
+                if (block.Protocol != expectedProtocol)
+                {
+                    throw new BlockGenerationException($"invalid protocol number {block.Protocol}, expected protocol {expectedProtocol}");
+                }
 
-            using (var m = new ProfileMarker("CloseBlock"))
-            {
-                if (allowModify)
+                using (var m = new ProfileMarker("CloseBlock"))
                 {
-                    CloseBlock(block, changeSet);
+                        CloseBlock(block, changeSet);
                 }
             }