Skip to content

Commit 3c4f31e

Browse files
author
epriestley
committed
Dynamically composite favicons from customizable sources
Summary: Ref T13103. Make favicons customizable, and perform dynamic compositing to add marker to indicate things like "unread messages". Test Plan: Viewed favicons in Safari, Firefox and Chrome. With unread messages, saw pink dot composited into icon. Maniphest Tasks: T13103 Differential Revision: https://secure.phabricator.com/D19209
1 parent 9d0cf3c commit 3c4f31e

33 files changed

+605
-112
lines changed
1.43 KB
Loading
1.11 KB
Loading

resources/celerity/map.php

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
'differential.pkg.js' => 'f6d809c0',
1717
'diffusion.pkg.css' => 'a2d17c7d',
1818
'diffusion.pkg.js' => '6134c5a1',
19-
'favicon.ico' => '30672e08',
2019
'maniphest.pkg.css' => '4845691a',
2120
'maniphest.pkg.js' => '4d7e79c8',
2221
'rsrc/audio/basic/alert.mp3' => '98461568',
@@ -270,28 +269,8 @@
270269
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
271270
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js' => 'ab9e0a82',
272271
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js' => '6c0e62fa',
273-
'rsrc/favicons/apple-touch-icon-114x114.png' => '12a24178',
274-
'rsrc/favicons/apple-touch-icon-120x120.png' => '0d1543c7',
275-
'rsrc/favicons/apple-touch-icon-144x144.png' => '8043b5a5',
276-
'rsrc/favicons/apple-touch-icon-152x152.png' => '65905ecd',
277-
'rsrc/favicons/apple-touch-icon-57x57.png' => '2bfc7b0a',
278-
'rsrc/favicons/apple-touch-icon-60x60.png' => '8ff52925',
279-
'rsrc/favicons/apple-touch-icon-72x72.png' => 'a2bb65d6',
280-
'rsrc/favicons/apple-touch-icon-76x76.png' => '2d061a11',
281-
'rsrc/favicons/favicon-128.png' => '72f7e812',
282272
'rsrc/favicons/favicon-16x16.png' => 'fc6275ba',
283-
'rsrc/favicons/favicon-196x196.png' => '95db275e',
284-
'rsrc/favicons/favicon-32x32.png' => '5bd18b6c',
285-
'rsrc/favicons/favicon-96x96.png' => '7242c8e9',
286-
'rsrc/favicons/favicon-mention.ico' => '1fdd0fa4',
287-
'rsrc/favicons/favicon-message.ico' => '115bc010',
288-
'rsrc/favicons/favicon.ico' => 'cdb11121',
289273
'rsrc/favicons/mask-icon.svg' => 'e132a80f',
290-
'rsrc/favicons/mstile-144x144.png' => '310c2ee5',
291-
'rsrc/favicons/mstile-150x150.png' => '74bf5133',
292-
'rsrc/favicons/mstile-310x150.png' => '4a49d3ee',
293-
'rsrc/favicons/mstile-310x310.png' => 'a52ab264',
294-
'rsrc/favicons/mstile-70x70.png' => '5edce7b8',
295274
'rsrc/image/BFCFDA.png' => 'd5ec91f4',
296275
'rsrc/image/actions/edit.png' => '2fc41442',
297276
'rsrc/image/avatar.png' => '17d346a4',

src/__phutil_library_map__.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2953,6 +2953,8 @@
29532953
'PhabricatorFactObjectDimension' => 'applications/fact/storage/PhabricatorFactObjectDimension.php',
29542954
'PhabricatorFactRaw' => 'applications/fact/storage/PhabricatorFactRaw.php',
29552955
'PhabricatorFactUpdateIterator' => 'applications/fact/extract/PhabricatorFactUpdateIterator.php',
2956+
'PhabricatorFaviconRef' => 'applications/files/favicon/PhabricatorFaviconRef.php',
2957+
'PhabricatorFaviconRefQuery' => 'applications/files/favicon/PhabricatorFaviconRefQuery.php',
29562958
'PhabricatorFavoritesApplication' => 'applications/favorites/application/PhabricatorFavoritesApplication.php',
29572959
'PhabricatorFavoritesController' => 'applications/favorites/controller/PhabricatorFavoritesController.php',
29582960
'PhabricatorFavoritesMainMenuBarExtension' => 'applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php',
@@ -4331,7 +4333,6 @@
43314333
'PhabricatorSystemDAO' => 'applications/system/storage/PhabricatorSystemDAO.php',
43324334
'PhabricatorSystemDestructionGarbageCollector' => 'applications/system/garbagecollector/PhabricatorSystemDestructionGarbageCollector.php',
43334335
'PhabricatorSystemDestructionLog' => 'applications/system/storage/PhabricatorSystemDestructionLog.php',
4334-
'PhabricatorSystemFaviconController' => 'applications/system/controller/PhabricatorSystemFaviconController.php',
43354336
'PhabricatorSystemReadOnlyController' => 'applications/system/controller/PhabricatorSystemReadOnlyController.php',
43364337
'PhabricatorSystemRemoveDestroyWorkflow' => 'applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php',
43374338
'PhabricatorSystemRemoveLogWorkflow' => 'applications/system/management/PhabricatorSystemRemoveLogWorkflow.php',
@@ -8512,6 +8513,8 @@
85128513
'PhabricatorFactObjectDimension' => 'PhabricatorFactDimension',
85138514
'PhabricatorFactRaw' => 'PhabricatorFactDAO',
85148515
'PhabricatorFactUpdateIterator' => 'PhutilBufferedIterator',
8516+
'PhabricatorFaviconRef' => 'Phobject',
8517+
'PhabricatorFaviconRefQuery' => 'Phobject',
85158518
'PhabricatorFavoritesApplication' => 'PhabricatorApplication',
85168519
'PhabricatorFavoritesController' => 'PhabricatorController',
85178520
'PhabricatorFavoritesMainMenuBarExtension' => 'PhabricatorMainMenuBarExtension',
@@ -10142,7 +10145,6 @@
1014210145
'PhabricatorSystemDAO' => 'PhabricatorLiskDAO',
1014310146
'PhabricatorSystemDestructionGarbageCollector' => 'PhabricatorGarbageCollector',
1014410147
'PhabricatorSystemDestructionLog' => 'PhabricatorSystemDAO',
10145-
'PhabricatorSystemFaviconController' => 'PhabricatorController',
1014610148
'PhabricatorSystemReadOnlyController' => 'PhabricatorController',
1014710149
'PhabricatorSystemRemoveDestroyWorkflow' => 'PhabricatorSystemRemoveWorkflow',
1014810150
'PhabricatorSystemRemoveLogWorkflow' => 'PhabricatorSystemRemoveWorkflow',

src/applications/config/option/PhabricatorUIConfigOptions.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ public function getOptions() {
6464
"Phabricator logo in the site header.\n\n".
6565
" - **Wordmark**: Choose new text to display next to the logo. ".
6666
"By default, the header displays //Phabricator//.\n\n")),
67+
$this->newOption('ui.favicons', 'wild', array())
68+
->setSummary(pht('Customize favicons.'))
69+
->setDescription(pht('Customize favicons.'))
70+
->setLocked(true),
6771
$this->newOption('ui.footer-items', $footer_type, array())
6872
->setSummary(
6973
pht(

0 commit comments

Comments
 (0)