Release 2.2.14

Author: Thomas Hunziker

README.md

@@ -23,7 +23,7 @@ Add this dependency to your project's POM:
 <dependency>
     <groupId>com.postfinancecheckout</groupId>
     <artifactId>postfinancecheckout-java-sdk</artifactId>
-    <version>2.2.13</version>
+    <version>2.2.14</version>
     <scope>compile</scope>
 </dependency>
 ```
@@ -33,7 +33,7 @@ Add this dependency to your project's POM:
 Add this dependency to your project's build file:
 
 ```groovy
-compile "com.postfinancecheckout:postfinancecheckout-java-sdk:2.2.13"
+compile "com.postfinancecheckout:postfinancecheckout-java-sdk:2.2.14"
 ```
 
 ### Others
@@ -46,7 +46,7 @@ mvn clean package
 
 Then manually install the following JARs:
 
-* `target/postfinancecheckout-java-sdk-2.2.13.jar`
+* `target/postfinancecheckout-java-sdk-2.2.14.jar`
 * `target/lib/*.jar`
 
 ## Usage

build.gradle

@@ -2,7 +2,7 @@ apply plugin: 'idea'
 apply plugin: 'eclipse'
 
 group = 'com.postfinancecheckout'
-version = '2.2.13'
+version = '2.2.14'
 
 buildscript {
     repositories {

build.sbt

@@ -2,7 +2,7 @@ lazy val root = (project in file(".")).
   settings(
     organization := "com.postfinancecheckout",
     name := "postfinancecheckout-java-sdk",
-    version := "2.2.13",
+    version := "2.2.14",
     scalaVersion := "2.11.4",
     scalacOptions ++= Seq("-feature"),
     javacOptions in compile ++= Seq("-Xlint:deprecation"),

pom.xml

@@ -5,7 +5,7 @@
     <artifactId>postfinancecheckout-java-sdk</artifactId>
     <packaging>jar</packaging>
     <name>postfinancecheckout-java-sdk</name>
-    <version>2.2.13</version>
+    <version>2.2.14</version>
     <url>https://www.postfinance.ch/checkout</url>
     <description>The SDK for simplifying the integration with PostFinance Checkout API.</description>
     <scm>

src/test/java/com/postfinancecheckout/sdk/test/PaymentTerminalTillServiceTest.java

@@ -50,7 +50,7 @@ private TransactionCreate getTransactionPayload() {
                     .amountIncludingTax(BigDecimal.valueOf(29.95))
                     .sku("red-t-shirt-123");
 
-            // Customer Billind Address
+            // Customer Billing Address
             AddressCreate billingAddress = new AddressCreate();
             billingAddress.city("Winterthur")
                     .country("CH")
@@ -150,64 +150,42 @@ public void readTest() {
      * This operation creates and executes a refund of a particular transaction.
      */
     @Test
-    public void refundTest() {
-        try {
-            Transaction transaction = this.apiClient.getTransactionService().create(this.spaceId, this.getTransactionPayload());
-	        // wait for transaction to be authorized
-            for (int i = 1; i <= 5; i++) {
-                if (transaction.getState() == TransactionState.AUTHORIZED) {
-                    break;
-                }
-                System.out.println("Waiting for transaction for be authorized --- transaction current state: " + transaction.getState());
-
-                try {
-                    Thread.sleep(i * 15000);
-                } catch (InterruptedException e) {
-                    System.err.println(e.getMessage());
-                }
-                transaction = this.apiClient.getTransactionService().read(this.spaceId, transaction.getId());
-            }
-			if (transaction.getState() == TransactionState.AUTHORIZED) {
-				transaction = this.apiClient.getTransactionService().processWithoutUserInteraction(this.spaceId, transaction.getId());
-				for (int i = 1; i <= 5; i++) {
-					if (
-						transaction.getState() == TransactionState.FULFILL ||
-						transaction.getState() == TransactionState.FAILED
-					) {
-						break;
-					}
-
-					try {
-						Thread.sleep(i * 15000);
-					} catch (InterruptedException e) {
-						System.err.println(e.getMessage());
-					}
-					transaction = this.apiClient.getTransactionService().read(this.spaceId, transaction.getId());
-				}
-
-				if (transaction.getState() == TransactionState.FULFILL) {
-					TransactionCompletion transactionCompletion = this.apiClient.getTransactionCompletionService().completeOffline(this.spaceId, transaction.getId());
-					Assert.assertEquals(
-							"Transaction completion successful",
-							transactionCompletion.getState(),
-							TransactionCompletionState.SUCCESSFUL
-					);
-
-					transaction = this.apiClient.getTransactionService().read(transaction.getLinkedSpaceId(), transactionCompletion.getLinkedTransaction());
-					Refund refund = this.apiClient.getRefundService().refund(this.spaceId, getRefundPayload(transaction));
-
-					Assert.assertEquals(
-							"Refund successful",
-							refund.getState(),
-							RefundState.SUCCESSFUL
-					);
-				}
-			} else {
-				Assert.assertTrue(transaction.getState() != TransactionState.AUTHORIZED);
+    public void refundTest() throws Exception {
+        Transaction transaction = this.apiClient.getTransactionService().create(this.spaceId, this.getTransactionPayload());
+        transaction = this.apiClient.getTransactionService().processWithoutUserInteraction(spaceId, transaction.getId());
+        // wait for transaction to be authorized
+		for (int i = 1; i <= 10; i++) {
+			if (
+				transaction.getState() == TransactionState.FULFILL ||
+				transaction.getState() == TransactionState.FAILED
+			) {
+				break;
 			}
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
+
+			try {
+				Thread.sleep(i * 500);
+			} catch (InterruptedException e) {
+				System.err.println(e.getMessage());
+			}
+			transaction = this.apiClient.getTransactionService().read(this.spaceId, transaction.getId());
+		}
+		Assert.assertEquals(TransactionState.FULFILL, transaction.getState());
+ 
+		TransactionCompletion transactionCompletion = this.apiClient.getTransactionCompletionService().completeOffline(this.spaceId, transaction.getId());
+		Assert.assertEquals(
+				"Transaction completion successful",
+				transactionCompletion.getState(),
+				TransactionCompletionState.SUCCESSFUL
+		);
+
+		transaction = this.apiClient.getTransactionService().read(transaction.getLinkedSpaceId(), transactionCompletion.getLinkedTransaction());
+		Refund refund = this.apiClient.getRefundService().refund(this.spaceId, getRefundPayload(transaction));
+
+		Assert.assertEquals(
+				"Refund successful",
+				refund.getState(),
+				RefundState.SUCCESSFUL
+		);
     }
 
     /**