Skip to content

Commit 86b1342

Browse files
authored
Merge pull request #5 from petfinder-com/bug/unsafe-header-user-agent
remove user-agent header
2 parents 233f567 + 1998173 commit 86b1342

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@petfinder/petfinder-js",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"description": "Petfinder API client",
55
"repository": {
66
"type": "git",

src/main.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Client {
1919
this.config = config;
2020
this.http = axios.create({
2121
baseURL: config.baseUrl || "https://api.petfinder.com/v2",
22-
headers: {"User-Agent": "petfinder-js-sdk/v1.0 (https://github.com/petfinder-com/petfinder-js-sdk)"},
22+
headers: {"x-api-sdk": "petfinder-js-sdk/v1.0 (https://github.com/petfinder-com/petfinder-js-sdk)"},
2323
});
2424

2525
this.http.interceptors.response.use((response: AxiosResponse) => {

tests/main.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ it("Should be able to get sub clients", () => {
6161
expect(client.organization).toBeInstanceOf(Organization);
6262
});
6363

64-
it("Should include an identifiable user agent", async () => {
64+
it("Should include an identifiable header", async () => {
6565
const mock = new MockAdapter(axios);
6666
mock.onGet("/").replyOnce(200);
6767

@@ -70,6 +70,6 @@ it("Should include an identifiable user agent", async () => {
7070

7171
expect(response.status).toEqual(200);
7272
expect(mock.history.get.length).toEqual(1);
73-
expect(mock.history.get[0].headers["User-Agent"])
73+
expect(mock.history.get[0].headers["x-api-sdk"])
7474
.toEqual("petfinder-js-sdk/v1.0 (https://github.com/petfinder-com/petfinder-js-sdk)");
7575
});

0 commit comments

Comments
 (0)