fixup! Refactor some lower level functions in tde_keyring

Author: AndersAstrand

contrib/pg_tde/src/catalog/tde_keyring.c

@@ -562,11 +562,12 @@ save_new_key_provider_info(KeyringProviderRecord *provider, Oid databaseId, bool
 	}
 	close(fd);
 
-	/*
-	 * TODO: Should we use overflow aware integer math here? (and then also
-	 * not blindly do abs() on something that might be INT_MIN above). It
-	 * would be overkill to do that, wouldn't it?
-	 */
+	if (max_provider_id == PG_INT32_MAX)
+	{
+		ereport(ERROR,
+				errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
+				errmsg("cannot create key provider, id out of range"));
+	}
 	new_provider_id = max_provider_id + 1;
 	provider->provider_id = (databaseId == GLOBAL_DATA_TDE_OID ? -new_provider_id : new_provider_id);