Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction view should group auction NFTs #2001

Open
turbocrime opened this issue Jan 27, 2025 · 1 comment
Open

Transaction view should group auction NFTs #2001

turbocrime opened this issue Jan 27, 2025 · 1 comment
Labels
ui Related to user interface or ux design

Comments

@turbocrime
Copy link
Collaborator

turbocrime commented Jan 27, 2025

Is your feature request related to a problem? Please describe.

Auction NFTs result in excessively verbose transaction views. Scrolling to find useful information is annoying.

Scheduling will typically create many auction NFT outputs. Similarly, ending and withdrawing may involve dozens of inputs and outputs. All auction NFTs are listed individually in the transaction view.

But, the user does not care that these transactions are manipulating many NFTs.

Describe the solution you'd like

The user cares about inputs and outputs. Typically all auction NFTs in a single transaction correspond to very few asset pairs, usually a single pair. Any 'end' action will have a 1:1 correspondence between auction NFT inputs and outputs.

The user cares about deliberate activity. Typically all auction NFTs in a single transaction will correspond to very few initiating transactions. An auction may 'end' early by choice, or complete as scheduled and only 'end' as a bookkeeping step before withdrawal.

So the transaction view could group involved auction NFTs:

  • by trading pair
  • by scheduling transaction
  • by NFT pair
  • by status at 'end'

Grouping auction NFTs into fewer displayed items would make transaction views much more compact and easier to navigate.

Describe alternatives you've considered

The assets dashboard page and asset picker components already filter auction NFTs from display. But in a transaction view, auction NFTs are relevant, and should not be completely filtered.

Additional context

A collapsed group should be expandable to view details.

Raw JSON is available to users interested in complete data.

It is technically possible to create transactions containing sets of actions that don't meet the above expectations.

The batch end and batch withdraw tools could take advantage of the same grouping code to create transactions that anticipate this kind of viewing.

@TalDerei
Copy link
Contributor

TalDerei commented Jan 28, 2025

our UIv2 library includes figma designs for rendering auctions, and grouping the auction NFTs would be another view on top of that (think we have designs for that as well?).

@TalDerei TalDerei added the ui Related to user interface or ux design label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to user interface or ux design
Projects
None yet
Development

No branches or pull requests

2 participants