We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here Liquidity is being incorrectly mapped to the volume variable.
// TODO: should this be `direct_volume_over_window`? let volume = toValueView({ amount: summary.liquidity, metadata: quoteAsset, });
https://github.com/penumbra-zone/dex-explorer/blob/main/src/shared/api/server/summary/pairs.ts#L55-L58
this manifest as the Selector widget showing liquidity but referring to it as volume.
I'm not clear if we want to fix the API or just change volume -> liquidity everywhere.
Thoughts?
The text was updated successfully, but these errors were encountered:
Thanks for the helpful bug/experience report. I think we want to:
So the actionable item for this bug report is to use the right input for the volume rendering.
Sorry, something went wrong.
No branches or pull requests
Here Liquidity is being incorrectly mapped to the volume variable.
https://github.com/penumbra-zone/dex-explorer/blob/main/src/shared/api/server/summary/pairs.ts#L55-L58
this manifest as the Selector widget showing liquidity but referring to it as volume.
I'm not clear if we want to fix the API or just change volume -> liquidity everywhere.
Thoughts?
The text was updated successfully, but these errors were encountered: