Fix detekt warnings

Author: penguin-boxx

Diff for: lambdarpc/config/detekt.yml

@@ -0,0 +1,33 @@
+complexity:
+  # Functions boilerplate for multiple args
+  LongParameterList:
+    excludes: [ '**/functions/frontend/**' ]
+
+exceptions:
+  # Temporal, proper error handling should be implemented
+  TooGenericExceptionCaught:
+    excludes: [ '**/LibServiceImpl.kt', '**/AbstractConnectedFunction.kt' ]
+
+formatting:
+  # IDEA automatically folds imports by default
+  NoWildcardImports:
+    active: false
+  # Does not agree with default formatting
+  Indentation:
+    excludes: ['**/exceptions/Exceptions.kt']
+
+style:
+  # IDEA automatically folds imports by default
+  WildcardImport:
+    active: false
+  # Checking arguments list size in boilerplate implementations
+  MagicNumber:
+    excludes: ['**/BackendFunction.kt']
+
+naming:
+  # Does not always agree with IDEA default warnings
+  FunctionNaming:
+    active: false
+  # Is not suitable for DSL
+  MatchingDeclarationName:
+    excludes: ['**/dsl/**']

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/dsl/LibService.kt

@@ -19,7 +19,8 @@ class ServiceNotFound internal constructor(id: ServiceId) : LambdaRpcException("
  * DSL class that creates libservice instance.
  */
 class LibService(
-    serviceId: ServiceId, endpoint: Endpoint,
+    serviceId: ServiceId,
+    endpoint: Endpoint,
     serviceRegistry: ServiceRegistry = MapServiceRegistry(),
     builder: LibServiceDSL.() -> Unit
 ) {

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/dsl/ServiceDispatcher.kt

@@ -10,7 +10,7 @@ import io.lambdarpc.utils.ServiceId
 import io.lambdarpc.utils.associateRepeatable
 import io.lambdarpc.utils.sid
 import kotlinx.coroutines.CoroutineScope
-import java.util.*
+import java.util.UUID
 import kotlin.coroutines.AbstractCoroutineContextElement
 import kotlin.coroutines.CoroutineContext
 

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/functions/FunctionCoder.kt

@@ -108,7 +108,6 @@ internal class FunctionCoder0<R>(
             rc
         )
     }
-
 }
 
 internal class FunctionCoder1<A, R>(

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/functions/frontend/AbstractConnectedFunction.kt

@@ -102,7 +102,9 @@ internal abstract class AbstractConnectedFunction : KLoggable {
                 outMessages.collectApply {
                     when {
                         hasFinalResponse() -> {
-                            logger.info { "${accessName}: final response received with id = ${finalResponse.executionId}" }
+                            logger.info {
+                                "$accessName: final response received with id = ${finalResponse.executionId}"
+                            }
                             result = finalResponse
                             cancel()
                         }

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/service/LibServiceImpl.kt

@@ -181,13 +181,14 @@ internal class LibServiceImpl(
             val oldName = function.channelFunction.accessName
             val f = localFunctionRegistry[oldName.an] ?: error("Function $oldName does not exist kek")
             val name = functionRegistry.register(f)
-            Entity(FunctionPrototype(object : BoundFunction {
+            val boundFunction = object : BoundFunction {
                 override val accessName: AccessName
                     get() = name
                 override val serviceId: ServiceId
                     get() = this@LibServiceImpl.serviceId
                 override val endpoint: Endpoint
                     get() = this@LibServiceImpl.endpoint
-            }))
+            }
+            Entity(FunctionPrototype(boundFunction))
         }
 }

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/transport/grpc/serialization/Defs.kt renamed to lambdarpc/src/main/kotlin/io/lambdarpc/transport/grpc/serialization/RawData.kt

@@ -5,5 +5,4 @@ import io.lambdarpc.transport.grpc.LibServiceGrpcKt
 /**
  * gRPC libservice abstract implementation.
  */
-internal abstract class AbstractLibService
-    : LibServiceGrpcKt.LibServiceCoroutineImplBase()
+internal abstract class AbstractLibService : LibServiceGrpcKt.LibServiceCoroutineImplBase()

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/transport/grpc/service/AbstractLibService.kt

@@ -10,7 +10,6 @@ value class AccessName(val n: String) {
 val String.an: AccessName
     get() = AccessName(this)
 
-
 @JvmInline
 value class ExecutionId(private val id: UUID) {
     override fun toString(): String = id.toString()
@@ -25,7 +24,6 @@ val UUID.eid: ExecutionId
 
 fun String.toEid() = ExecutionId(UUID.fromString(this))
 
-
 @JvmInline
 value class ServiceId(private val id: UUID) {
     override fun toString(): String = id.toString()

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/utils/Defs.kt

@@ -6,14 +6,12 @@ value class Address(val a: String)
 val String.addr: Address
     get() = Address(this)
 
-
 @JvmInline
 value class Port(val p: Int)
 
 val Int.port: Port
     get() = Port(this)
 
-
 data class Endpoint(val address: Address, val port: Port) {
     override fun toString(): String = "${address.a}:${port.p}"
 }

Diff for: lambdarpc/src/main/kotlin/io/lambdarpc/utils/Endpoint.kt

@@ -1,8 +1,6 @@
 package io.lambdarpc.utils
 
 import kotlinx.coroutines.flow.Flow
-import java.util.concurrent.atomic.AtomicReference
-import kotlin.reflect.KProperty
 
 operator fun <K, V> Map<out K, List<V>>.plus(
     map: Map<out K, List<V>>
@@ -40,8 +38,5 @@ inline fun <T, K, V> Iterable<T>.associateRepeatable(
 
 fun unreachable(explanation: String): Nothing = error("Unreachable code reached: $explanation")
 
-operator fun <V> AtomicReference<V>.getValue(_owner: Any?, property: KProperty<*>): V = get()
-operator fun <V> AtomicReference<V>.setValue(_owner: Any?, property: KProperty<*>, value: V) = set(value)
-
 suspend fun <T> Flow<T>.collectApply(block: suspend T.() -> Unit) =
     collect { it.block() }