Skip to content

Commit da49137

Browse files
committed
Revert "fix: undefined will stay undefined instead of null"
Changing the encoding of `undefined` is a breaking change. I am postponing this so we can bundle this with other breaking changes. It’s still a good idea to change this eventually. This reverts commit 83af274.
1 parent 275c600 commit da49137

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

__test__/bugs.spec.ts

+5
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ import { expect, describe, it } from "@jest/globals";
33
import { packAndUnpack } from "./util";
44

55
describe("Bugs", () => {
6+
describe("Objects", () => {
7+
it("replaces undefined with null ", async () => {
8+
expect(await packAndUnpack(undefined)).toBe(null);
9+
});
10+
});
611
describe("Numbers", () => {
712
it("gives back wrong value on INT64_MAX ", async () => {
813
expect(await packAndUnpack(0x7fffffffffffffff)).toBe(

__test__/objects.spec.ts

-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ describe("Binarypack", () => {
3131
it("should keep null", async () => {
3232
expect(await packAndUnpack(null)).toEqual(null);
3333
});
34-
it("should keep undefined", async () => {
35-
expect(await packAndUnpack(undefined)).toEqual(undefined);
36-
});
3734

3835
it("should transfer Uint8Array views correctly", async () => {
3936
const arr = new Uint8Array(8);

lib/binarypack.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ export class Packer {
312312
this._bufferBuilder.append(0xc2);
313313
}
314314
} else if (value === undefined) {
315-
this._bufferBuilder.append(0xc1);
315+
this._bufferBuilder.append(0xc0);
316316
} else if (typeof value === "object") {
317317
if (value === null) {
318318
this._bufferBuilder.append(0xc0);

0 commit comments

Comments
 (0)