forked from dotnet/runtime
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathHttpHeadersTest.cs
2855 lines (2228 loc) · 122 KB
/
HttpHeadersTest.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Net.Http.Headers;
using System.Tests;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
namespace System.Net.Http.Tests
{
public class HttpHeadersTest
{
// Note: These are not real known headers, so they won't be returned if we call HeaderDescriptor.Get().
private static readonly HeaderDescriptor known1Header = (new KnownHeader("known1", HttpHeaderType.General, new MockHeaderParser())).Descriptor;
private static readonly HeaderDescriptor known2Header = (new KnownHeader("known2", HttpHeaderType.General, new MockHeaderParser())).Descriptor;
private static readonly HeaderDescriptor known3Header = (new KnownHeader("known3", HttpHeaderType.General, new MockHeaderParser())).Descriptor;
private static readonly HeaderDescriptor known4Header = (new KnownHeader("known3", HttpHeaderType.General, new CustomTypeHeaderParser())).Descriptor;
private static readonly HeaderDescriptor noComparerHeader = (new KnownHeader("noComparerHeader", HttpHeaderType.General, new NoComparerHeaderParser())).Descriptor;
private static readonly HeaderDescriptor customTypeHeader = (new KnownHeader("customTypeHeader", HttpHeaderType.General, new CustomTypeHeaderParser())).Descriptor;
private static readonly HeaderDescriptor customHeader;
static HttpHeadersTest()
{
HeaderDescriptor.TryGet("custom", out customHeader);
}
private const string customHeaderName = "custom-header";
private const string rawPrefix = "raw";
private const string parsedPrefix = "parsed";
private const string invalidHeaderValue = "invalid";
[Fact]
public void TryAddWithoutValidation_ValidAndInvalidValues_InsertionOrderIsPreserved()
{
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, "http://microsoft.com");
request.Headers.TryAddWithoutValidation("Accept", "text/bar");
request.Headers.TryAddWithoutValidation("Accept", "invalid");
request.Headers.TryAddWithoutValidation("Accept", "text/baz");
// Force parsing
_ = request.Headers.Accept.Count;
Assert.Equal(1, request.Headers.NonValidated.Count);
HeaderStringValues accept = request.Headers.NonValidated["Accept"];
Assert.Equal(new[] { "text/bar", "invalid", "text/baz" }, accept);
}
[Fact]
public void MixedAddAndTryAddWithoutValidation_ParsedAndRawValues_InsertionOrderIsPreserved()
{
HttpHeaders headers = new HttpRequestMessage().Headers;
headers.Add("Accept", "text/foo");
headers.TryAddWithoutValidation("Accept", "text/bar");
headers.TryAddWithoutValidation("Accept", "invalid");
var expectedValues = new string[] { "text/foo", "text/bar", "invalid" };
Assert.Equal(expectedValues, headers.NonValidated["Accept"]);
Assert.True(headers.TryGetValues("Accept", out IEnumerable<string>? values));
Assert.Equal(expectedValues, values);
Assert.Equal(expectedValues, headers.NonValidated["Accept"]);
}
[Fact]
public void TryAddWithoutValidation_AddInvalidViaHeaderValue_ValuePassed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation("Via", "1.1 foo.bar, foo");
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal("1.1 foo.bar, foo", headers.First().Value.ElementAt(0));
}
[Theory]
[InlineData(null)]
[InlineData("")]
public void TryAddWithoutValidation_UseEmptyHeaderName_False(string headerName)
{
MockHeaders headers = new MockHeaders();
Assert.False(headers.TryAddWithoutValidation(headerName, "value"));
}
[Theory]
[MemberData(nameof(GetInvalidHeaderNames))]
public void TryAddWithoutValidation_UseInvalidHeaderName_False(string headerName)
{
MockHeaders headers = new MockHeaders();
Assert.False(headers.TryAddWithoutValidation(headerName, "value"));
}
[Fact]
public void TryAddWithoutValidation_AddSingleValue_ValueParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix, headers.First().Value.First());
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddTwoSingleValues_BothValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "2");
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddTwoValidValuesAsOneString_BothValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1," + rawPrefix + "2");
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
// The parser gets called for each value in the raw string. I.e. if we have 1 raw string containing two
// values, the parser gets called twice.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddTwoValuesOneValidOneInvalidAsOneString_RawStringAddedAsInvalid()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1," + invalidHeaderValue);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
// We expect the value to be returned without change since it couldn't be parsed in its entirety.
Assert.Equal(rawPrefix + "1," + invalidHeaderValue, headers.First().Value.ElementAt(0));
// The parser gets called twice, but the second time it returns false, because it tries to parse
// 'invalidHeaderValue'.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddTwoValueStringAndThirdValue_AllValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1," + rawPrefix + "2");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "3");
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(parsedPrefix + "3", headers.First().Value.ElementAt(2));
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddInvalidAndValidValueString_BothValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix);
headers.TryAddWithoutValidation(headers.Descriptor, invalidHeaderValue);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix, headers.First().Value.ElementAt(0));
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(1));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddEmptyValueString_HeaderWithNoValueAfterParsing()
{
MockHeaders headers = new MockHeaders();
// The parser returns 'true' to indicate that it could parse the value (empty values allowed) and an
// value of 'null'.
headers.TryAddWithoutValidation(headers.Descriptor, string.Empty);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
headers.Clear();
headers.TryAddWithoutValidation("custom", (string)null);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(string.Empty, headers.GetValues("custom").First());
}
[Fact]
public void TryAddWithoutValidation_AddValidAndInvalidValueString_BothValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, invalidHeaderValue);
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix, headers.First().Value.ElementAt(1));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
string expected = headers.Descriptor.Name + ": " + invalidHeaderValue + ", " + parsedPrefix + Environment.NewLine;
Assert.Equal(expected, headers.ToString());
}
[Fact]
public void TryAddWithoutValidation_AddNullValueForKnownHeader_ParserDoesNotRejectsNullEmptyStringAdded()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, (string)null);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
// MockParser is called with an empty string and decides that it is OK to have empty values.
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddNullValueForUnknownHeader_EmptyStringAddedAsValue()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(customHeaderName, (string)null);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
// 'null' values are internally stored as string.Empty. Since we added a custom header, there is no
// parser and the empty string is just added to the list of 'parsed values'.
Assert.Equal(string.Empty, headers.First().Value.First());
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddValueForUnknownHeader_ValueAddedToStore()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(customHeaderName, "custom value");
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal("custom value", headers.First().Value.First());
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddNullAndEmptyValuesToKnownHeader_HeaderNotRemovedFromCollection()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, (string)null);
headers.TryAddWithoutValidation(headers.Descriptor, string.Empty);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
// TryAddWithoutValidation() adds 'null' as string.empty to distinguish between an empty raw value and no raw
// value. When the parser is called later, the parser can decide whether empty strings are valid or not.
// In our case the MockParser returns 'success' with a parsed value of 'null' indicating that it is OK to
// have empty values.
Assert.Equal(2, headers.Parser.EmptyValueCount);
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddNullAndEmptyValuesToUnknownHeader_TwoEmptyStringsAddedAsValues()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(customHeaderName, (string)null);
headers.TryAddWithoutValidation(customHeaderName, string.Empty);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
// TryAddWithoutValidation() adds 'null' as string.empty to distinguish between an empty raw value and no raw
// value. For custom headers we just add what the user gives us. I.e. the result is a header with two empty
// values.
Assert.Equal(string.Empty, headers.First().Value.ElementAt(0));
Assert.Equal(string.Empty, headers.First().Value.ElementAt(1));
}
[Fact]
public void TryAddWithoutValidation_AddMultipleValueToSingleValueHeaders_FirstHeaderAddedOthersAreInvalid()
{
MockHeaderParser parser = new MockHeaderParser(false); // doesn't support multiple values.
MockHeaders headers = new MockHeaders(parser);
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "2");
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
// Note that the first value was parsed and added to the 'parsed values' list. The second value however
// was added to the 'invalid values' list since the header doesn't support multiple values.
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(rawPrefix + "2", headers.First().Value.ElementAt(1));
// The parser is only called once for the first value. HttpHeaders doesn't invoke the parser for
// additional values if the parser only supports one value.
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void TryAddWithoutValidation_AddMultipleValueStringToSingleValueHeaders_MultipleValueStringAddedAsInvalid()
{
MockHeaderParser parser = new MockHeaderParser(false); // doesn't support multiple values.
MockHeaders headers = new MockHeaders(parser);
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1," + rawPrefix + "2");
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
// Since parsing the header value fails because it is composed of 2 values, the original string is added
// to the list of 'invalid values'. Therefore we only have 1 header value (the original string).
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(rawPrefix + "1," + rawPrefix + "2", headers.First().Value.First());
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Theory]
[MemberData(nameof(HeaderValuesWithNewLines))]
public void TryAddWithoutValidation_AddValueContainingNewLine_InvalidValueSaved(string headerValue)
{
var headers = new HttpRequestHeaders();
// This value is considered invalid, however, since TryAddWithoutValidation() only causes the
// header value to be analyzed when it gets actually accessed, no exception is thrown.
headers.TryAddWithoutValidation("foo", headerValue);
Assert.True(headers.Contains("foo"));
Assert.Equal(1, headers.NonValidated.Count);
Assert.Equal(headerValue, headers.NonValidated["foo"].ToString());
Assert.Equal(1, headers.Count());
Assert.True(headers.Contains("foo"));
Assert.Equal(1, headers.NonValidated.Count);
headers.Clear();
headers.TryAddWithoutValidation("foo", new[] { "valid", headerValue });
Assert.Equal(1, headers.NonValidated.Count);
Assert.Equal(new[] { "valid", headerValue }, headers.NonValidated["foo"]);
Assert.Equal(1, headers.Count());
Assert.Equal(new[] { "valid", headerValue }, headers.First().Value);
Assert.Equal(1, headers.NonValidated.Count);
Assert.Equal(new[] { "valid", headerValue }, headers.NonValidated["foo"]);
}
[Fact]
public void TryAddWithoutValidation_MultipleAddInvalidValuesToNonExistingHeader_AddHeader()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, new string[] { invalidHeaderValue });
// Make sure the header did not get added since we just tried to add an invalid value.
Assert.True(headers.Contains(headers.Descriptor));
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(0));
}
[Fact]
public void TryAddWithoutValidation_MultipleAddValidValueThenAddInvalidValuesToExistingHeader_AddValues()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, new string[] { rawPrefix + "2", invalidHeaderValue });
Assert.True(headers.Contains(headers.Descriptor));
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(2));
}
[Fact]
public void TryAddWithoutValidation_MultipleAddValidValueThenAddInvalidValuesToNonExistingHeader_AddHeader()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, new string[] { rawPrefix + "1", invalidHeaderValue });
Assert.True(headers.Contains(headers.Descriptor));
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(1));
}
[Fact]
public void TryAddWithoutValidation_MultipleAddNullValueCollection_Throws()
{
MockHeaders headers = new MockHeaders();
string[] values = null;
Assert.Throws<ArgumentNullException>(() => { headers.TryAddWithoutValidation(headers.Descriptor, values); });
}
[Theory]
[InlineData(null)]
public void Add_SingleUseNullHeaderName_Throw(string headerName)
{
MockHeaders headers = new MockHeaders();
AssertExtensions.Throws<ArgumentNullException>("name", () => { headers.Add(headerName, "value"); });
}
[Theory]
[InlineData("")]
[InlineData(" \t\r\n ")]
public void Add_SingleUseWhiteSpaceHeaderName_Throw(string headerName)
{
MockHeaders headers = new MockHeaders();
AssertExtensions.Throws<ArgumentException>("name", () => { headers.Add(headerName, "value"); });
}
[Theory]
[MemberData(nameof(GetInvalidHeaderNames))]
public void Add_SingleUseInvalidHeaderName_Throw(string headerName)
{
MockHeaders headers = new MockHeaders();
Assert.Throws<FormatException>(() => { headers.Add(headerName, "value"); });
}
[Fact]
public void Add_SingleUseStoreWithNoParserStore_AllHeadersConsideredCustom()
{
CustomTypeHeaders headers = new CustomTypeHeaders();
headers.Add("custom", "value");
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal("value", headers.First().Value.First());
}
[Fact]
public void Add_SingleAddValidValue_ValueParsedCorrectly()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix);
// Add() should trigger parsing.
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix, headers.First().Value.ElementAt(0));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleAddEmptyValueMultipleTimes_EmptyHeaderAdded()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, (string)null);
headers.Add(headers.Descriptor, string.Empty);
headers.Add(headers.Descriptor, string.Empty);
// Add() should trigger parsing.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
Assert.Equal(0, headers.Count());
}
[Fact]
public void Add_SingleAddInvalidValueToNonExistingHeader_ThrowAndDontAddHeader()
{
// Since Add() immediately parses the value, it will throw an exception if the value is invalid.
MockHeaders headers = new MockHeaders();
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, invalidHeaderValue); });
// Make sure the header did not get added to the store.
Assert.False(headers.Contains(headers.Descriptor),
"No header expected to be added since header value was invalid.");
}
[Fact]
public void Add_SingleAddValidValueThenAddInvalidValue_ThrowAndHeaderContainsValidValue()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix);
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, invalidHeaderValue); });
// Make sure the header did not get removed due to the failed add.
Assert.True(headers.Contains(headers.Descriptor), "Header was removed even if there is a valid header value.");
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix, headers.First().Value.ElementAt(0));
}
[Fact]
public void Add_MultipleAddInvalidValuesToNonExistingHeader_ThrowAndDontAddHeader()
{
MockHeaders headers = new MockHeaders();
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, new string[] { invalidHeaderValue }); });
// Make sure the header did not get added since we just tried to add an invalid value.
Assert.False(headers.Contains(headers.Descriptor), "Header was added even if we just added an invalid value.");
}
[Fact]
public void Add_MultipleAddValidValueThenAddInvalidValuesToExistingHeader_ThrowAndDontAddHeader()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, new string[] { rawPrefix + "2", invalidHeaderValue }); });
// Make sure the header did not get removed due to the failed add. Note that the first value in the array
// is valid, so it gets added. I.e. we have 2 values.
Assert.True(headers.Contains(headers.Descriptor), "Header was removed even if there is a valid header value.");
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
}
[Fact]
public void Add_MultipleAddValidValueThenAddInvalidValuesToNonExistingHeader_ThrowAndDontAddHeader()
{
MockHeaders headers = new MockHeaders();
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, new string[] { rawPrefix + "1", invalidHeaderValue }); });
// Make sure the header got added due to the valid add. Note that the first value in the array
// is valid, so it gets added.
Assert.True(headers.Contains(headers.Descriptor), "Header was not added even though we added 1 valid value.");
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
}
[Fact]
public void Add_SingleAddThreeValidValues_ValuesParsedCorrectly()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.Add(headers.Descriptor, rawPrefix + "2");
headers.Add(headers.Descriptor, rawPrefix + "3");
// Add() should trigger parsing.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(parsedPrefix + "3", headers.First().Value.ElementAt(2));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleAddTwoValidValuesToHeaderWithSingleValue_Throw()
{
MockHeaderParser parser = new MockHeaderParser(false); // doesn't support multiple values.
MockHeaders headers = new MockHeaders(parser);
headers.Add(headers.Descriptor, rawPrefix + "1");
// Can only add headers once.
Assert.Throws<FormatException>(() => { headers.Add(headers.Descriptor, rawPrefix + "2"); });
// Verify that the first header value is still there.
Assert.Equal(1, headers.First().Value.Count());
}
[Fact]
public void Add_SingleFirstTryAddWithoutValidationForValidValueThenAdd_TwoParsedValuesAdded()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1");
headers.Add(headers.Descriptor, rawPrefix + "2");
// Add() should trigger parsing. TryAddWithoutValidation() doesn't trigger parsing, but Add() triggers
// parsing of raw header values (TryParseValue() is called)
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleFirstTryAddWithoutValidationForInvalidValueThenAdd_TwoParsedValuesAdded()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, invalidHeaderValue);
headers.Add(headers.Descriptor, rawPrefix + "1");
// Add() should trigger parsing. TryAddWithoutValidation() doesn't trigger parsing, but Add() triggers
// parsing of raw header values (TryParseValue() is called)
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(invalidHeaderValue, headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(1));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleFirstTryAddWithoutValidationForEmptyValueThenAdd_TwoParsedValueAddedEmptyNotIgnored()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, string.Empty);
headers.Add(headers.Descriptor, rawPrefix + "1");
// Add() should trigger parsing. TryAddWithoutValidation() doesn't trigger parsing, but Add() triggers
// parsing of raw header values (TryParseValue() is called)
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(1));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleFirstAddThenTryAddWithoutValidation_TwoParsedValuesAdded()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "2");
// Add() should trigger parsing. Since TryAddWithoutValidation() is called afterwards the second value is
// not parsed yet.
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleAddThenTryAddWithoutValidationThenAdd_ThreeParsedValuesAdded()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "2");
headers.Add(headers.Descriptor, rawPrefix + "3");
// The second Add() triggers also parsing of the value added by TryAddWithoutValidation()
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(parsedPrefix + "3", headers.First().Value.ElementAt(2));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleFirstTryAddWithoutValidationThenAddToSingleValueHeader_AddThrows()
{
MockHeaderParser parser = new MockHeaderParser(false); // doesn't support multiple values.
MockHeaders headers = new MockHeaders(parser);
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "1");
Assert.Throws<FormatException>(() => {headers.Add(headers.Descriptor, rawPrefix + "2"); });
}
[Fact]
public void Add_SingleFirstAddThenTryAddWithoutValidationToSingleValueHeader_BothParsedAndInvalidValue()
{
MockHeaderParser parser = new MockHeaderParser(false); // doesn't support multiple values.
MockHeaders headers = new MockHeaders(parser);
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.TryAddWithoutValidation(headers.Descriptor, rawPrefix + "2");
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
// Add() succeeds since we don't have a value added yet. TryAddWithoutValidation() also succeeds, however
// the value is added to the 'invalid values' list when retrieved.
Assert.Equal(1, headers.Count());
Assert.Equal(2, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(rawPrefix + "2", headers.First().Value.ElementAt(1));
// Note that TryParseValue() is not called because HttpHeaders sees that there is already a value
// so it adds the raw value to 'invalid values'.
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_MultipleAddThreeValidValuesWithOneCall_ValuesParsedCorrectly()
{
MockHeaders headers = new MockHeaders();
string[] values = new string[] { rawPrefix + "1", rawPrefix + "2", rawPrefix + "3" };
headers.Add(headers.Descriptor, values);
// Add() should trigger parsing.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(parsedPrefix + "3", headers.First().Value.ElementAt(2));
// Value is already parsed. There shouldn't be additional calls to the parser.
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_MultipleAddThreeValidValuesAsOneString_BothValuesParsed()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1," + rawPrefix + "2," + rawPrefix + "3");
Assert.Equal(3, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(3, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(1));
Assert.Equal(parsedPrefix + "3", headers.First().Value.ElementAt(2));
}
[Fact]
public void Add_MultipleAddNullValueCollection_Throw()
{
MockHeaders headers = new MockHeaders();
string[] values = null;
Assert.Throws<ArgumentNullException>(() => { headers.Add(headers.Descriptor, values); });
}
[Fact]
public void Add_SingleAddCustomHeaderWithNullValue_HeaderIsAddedWithEmptyStringValue()
{
MockHeaders headers = new MockHeaders();
headers.Add(customHeaderName, (string)null);
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(string.Empty, headers.First().Value.ElementAt(0));
// We're using a custom header. No parsing should be triggered.
Assert.Equal(0, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void Add_SingleAddHeadersWithDifferentCasing_ConsideredTheSameHeader()
{
MockHeaders headers = new MockHeaders();
headers.Add("custom-header", "value1");
headers.Add("Custom-Header", "value2");
headers.Add("CUSTOM-HEADER", "value2");
Assert.Equal(3, headers.GetValues("custom-header").Count());
Assert.Equal(3, headers.GetValues("Custom-Header").Count());
Assert.Equal(3, headers.GetValues("CUSTOM-HEADER").Count());
Assert.Equal(3, headers.GetValues("CuStOm-HeAdEr").Count());
}
[Theory]
[MemberData(nameof(HeaderValuesWithNewLines))]
public void Add_AddValueContainingNewLine_Rejected(string headerValue)
{
var headers = new HttpRequestHeaders();
Assert.Throws<FormatException>(() => headers.Add("foo", headerValue));
Assert.Equal(0, headers.Count());
Assert.Equal(0, headers.NonValidated.Count);
headers.Clear();
Assert.Throws<FormatException>(() => headers.Add("foo", new[] { "valid", headerValue }));
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal("valid", headers.First().Value.First());
Assert.Equal(1, headers.NonValidated.Count);
Assert.Equal("valid", headers.NonValidated["foo"].ToString());
}
[Fact]
public void RemoveParsedValue_AddValueAndRemoveIt_NoHeader()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
// Remove the parsed value (note the original string 'raw1' was "parsed" to 'parsed1')
Assert.True(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "1"));
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(0, headers.Count());
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
// Remove the value again: It shouldn't be found in the store.
Assert.False(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "1"));
}
[Fact]
public void RemoveParsedValue_AddInvalidValueAndRemoveValidValue_InvalidValueRemains()
{
MockHeaders headers = new MockHeaders();
headers.TryAddWithoutValidation(headers.Descriptor, invalidHeaderValue);
// Remove a valid value which is not in the store.
Assert.False(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix));
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(1, headers.Count());
Assert.Equal(invalidHeaderValue, headers.GetValues(headers.Descriptor).First());
Assert.Equal(1, headers.Parser.TryParseValueCallCount);
// Remove the value again: It shouldn't be found in the store.
Assert.False(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "1"));
}
[Fact]
public void RemoveParsedValue_ParserWithNoEqualityComparer_CaseSensitiveComparison()
{
CustomTypeHeaders headers = new CustomTypeHeaders();
headers.AddParsedValue(noComparerHeader, "lowercasevalue");
// Since we don't provide a comparer, the default string.Equals() is called which is case-sensitive. So
// the following call should return false.
Assert.False(headers.RemoveParsedValue(noComparerHeader, "LOWERCASEVALUE"));
// Now we try to remove the value using the correct casing. This should work.
Assert.True(headers.RemoveParsedValue(noComparerHeader, "lowercasevalue"));
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(0, headers.Count());
}
[Fact]
public void RemoveParsedValue_AddTwoValuesAndRemoveThem_NoHeader()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.Add(headers.Descriptor, rawPrefix + "2");
// Remove the parsed value (note the original string 'raw1' was "parsed" to 'parsed1')
Assert.True(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "1"));
Assert.True(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "2"));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(0, headers.Count());
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void RemoveParsedValue_AddTwoValuesAndRemoveFirstOne_SecondValueRemains()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.Add(headers.Descriptor, rawPrefix + "2");
// Remove the parsed value (note the original string 'raw1' was "parsed" to 'parsed1')
Assert.True(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "1"));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "2", headers.First().Value.ElementAt(0));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void RemoveParsedValue_AddTwoValuesAndRemoveSecondOne_FirstValueRemains()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix + "1");
headers.Add(headers.Descriptor, rawPrefix + "2");
// Remove the parsed value (note the original string 'raw2' was "parsed" to 'parsed2')
Assert.True(headers.RemoveParsedValue(headers.Descriptor, parsedPrefix + "2"));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
// Note that when the last value of a header gets removed, the whole header gets removed.
Assert.Equal(1, headers.Count());
Assert.Equal(1, headers.First().Value.Count());
Assert.Equal(parsedPrefix + "1", headers.First().Value.ElementAt(0));
Assert.Equal(2, headers.Parser.TryParseValueCallCount);
}
[Fact]
public void RemoveParsedValue_RemoveFromNonExistingHeader_ReturnsFalse()
{
MockHeaders headers = new MockHeaders();
headers.Add(headers.Descriptor, rawPrefix);
// Header 'non-existing-header' can't be found, so false is returned.
Assert.False(headers.RemoveParsedValue(customHeader, "doesntexist"));
}
[Fact]
public void RemoveParsedValue_RemoveFromUninitializedHeaderStore_ReturnsFalse()
{
MockHeaders headers = new MockHeaders();
// If we never add a header value, the whole header (and also the header store) doesn't exist.
// Make sure we considered this case.
Assert.False(headers.RemoveParsedValue(headers.Descriptor, "doesntexist"));
}
[Fact]
public void RemoveParsedValue_AddOneValueToKnownHeaderAndCompareWithValueThatDiffersInCase_CustomComparerUsedForComparison()
{
MockHeaders headers = new MockHeaders();
headers.AddParsedValue(headers.Descriptor, "value");
// Our custom comparer (MockComparer) does case-insensitive value comparison. Verify that our custom
// comparer is used to compare the header value.
Assert.True(headers.RemoveParsedValue(headers.Descriptor, "VALUE"));
Assert.False(headers.Contains(headers.Descriptor), "Header should be removed after removing value.");
Assert.Equal(1, headers.Parser.MockComparer.EqualsCount);
}