Skip to content

Commit 27efd23

Browse files
committed
CS fixes.
1 parent f4f24e9 commit 27efd23

File tree

3 files changed

+33
-32
lines changed

3 files changed

+33
-32
lines changed

stub.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@
7575
HEREDOC;
7676
}
7777

78-
if (class_exists('PEAR2\Cache\SHM', true))
79-
8078
if (function_exists('stream_socket_client')) {
8179
$failCode = constant(
8280
'PEAR2\Net\RouterOS\SocketException::CODE_CONNECTION_FAIL'

tests/ConnectionTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ public static function tearDownAfterClass()
4242

4343
public function testNormalEncryptedConnection()
4444
{
45-
// $this->markTestIncomplete(
46-
// 'There are issues with PHP itself regarding TLS connections'
47-
// );
4845
try {
4946
$routerOS = new Client(
5047
\HOSTNAME,

tests/HandlingTest.php

Lines changed: 33 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131
class RequestHandlingTest extends PHPUnit_Framework_TestCase
3232
{
3333
/**
34-
* @dataProvider providerNonAbsoluteCommand
35-
*
3634
* @param string $command
3735
*
36+
* @dataProvider providerNonAbsoluteCommand
37+
*
3838
* @return void
3939
*/
4040
public function testNonAbsoluteCommand($command)
@@ -61,10 +61,10 @@ public function providerNonAbsoluteCommand()
6161
}
6262

6363
/**
64-
* @dataProvider providerUnresolvableCommand
65-
*
6664
* @param string $command
6765
*
66+
* @dataProvider providerUnresolvableCommand
67+
*
6868
* @return void
6969
*/
7070
public function testUnresolvableCommand($command)
@@ -89,10 +89,10 @@ public function providerUnresolvableCommand()
8989
}
9090

9191
/**
92-
* @dataProvider providerInvalidCommand
93-
*
9492
* @param string $command
9593
*
94+
* @dataProvider providerInvalidCommand
95+
*
9696
* @return void
9797
*/
9898
public function testInvalidCommand($command)
@@ -118,11 +118,11 @@ public function providerInvalidCommand()
118118
}
119119

120120
/**
121-
* @dataProvider providerCommandTranslation
122-
*
123121
* @param string $command
124122
* @param string $expected
125123
*
124+
* @dataProvider providerCommandTranslation
125+
*
126126
* @return void
127127
*/
128128
public function testCommandTranslation($command, $expected)
@@ -150,12 +150,12 @@ public function providerCommandTranslation()
150150
}
151151

152152
/**
153-
* @dataProvider providerCommandAndArgumentParsing
154-
*
155153
* @param string $command
156154
* @param string $expected
157155
* @param array $args
158156
*
157+
* @dataProvider providerCommandAndArgumentParsing
158+
*
159159
* @return void
160160
*/
161161
public function testCommandAndArgumentParsing($command, $expected, $args)
@@ -592,10 +592,12 @@ public function providerCommandAndArgumentParsing()
592592
}
593593

594594
/**
595-
* @dataProvider providerCommandArgumentParsingExceptions
596-
*
597595
* @param string $command
598596
* @param int $code
597+
*
598+
* @dataProvider providerCommandArgumentParsingExceptions
599+
*
600+
* @return void
599601
*/
600602
public function testCommandArgumentParsingExceptions($command, $code)
601603
{
@@ -626,9 +628,11 @@ public function providerCommandArgumentParsingExceptions()
626628
}
627629

628630
/**
631+
* @param string $name
632+
*
629633
* @dataProvider providerInvalidArgumentName
630634
*
631-
* @param string $name
635+
* @return void
632636
*/
633637
public function testInvalidArgumentName($name)
634638
{
@@ -645,10 +649,10 @@ public function testInvalidArgumentName($name)
645649
}
646650

647651
/**
648-
* @dataProvider providerInvalidArgumentName
649-
*
650652
* @param string $name
651653
*
654+
* @dataProvider providerInvalidArgumentName
655+
*
652656
* @return void
653657
*/
654658
public function testInvalidQueryArgumentName($name)
@@ -690,9 +694,11 @@ public function testNonSeekableArgumentValue()
690694
}
691695

692696
/**
697+
* @param string|int $action
698+
*
693699
* @dataProvider providerInvalidQueryArgumentAction
694700
*
695-
* @param string|int $action
701+
* @return void
696702
*/
697703
public function testInvalidQueryArgumentAction($action)
698704
{
@@ -772,10 +778,10 @@ public function testArgumentRemoval()
772778
}
773779

774780
/**
775-
* @dataProvider providerLengths
776-
*
777781
* @param string $expected
778-
* @param int $length
782+
* @param int $length
783+
*
784+
* @dataProvider providerLengths
779785
*
780786
* @return void
781787
*/
@@ -793,10 +799,10 @@ public function testLengthEncoding($expected, $length)
793799
}
794800

795801
/**
796-
* @dataProvider providerLengths
797-
*
798802
* @param string $length
799-
* @param int $expected
803+
* @param int $expected
804+
*
805+
* @dataProvider providerLengths
800806
*
801807
* @return void
802808
*/
@@ -902,10 +908,10 @@ public function testLengthEncodingExceptions()
902908
}
903909

904910
/**
905-
* @dataProvider providerControlByte
906-
*
907911
* @param int $controlByte
908912
*
913+
* @dataProvider providerControlByte
914+
*
909915
* @return void
910916
*/
911917
public function testControlByteException($controlByte)
@@ -1157,10 +1163,10 @@ public function testTaglessModePassing()
11571163
}
11581164

11591165
/**
1160-
* @dataProvider providerUtilParseValue
1161-
*
11621166
* @param string $value
1163-
* @param mixed $expected
1167+
* @param mixed $expected
1168+
*
1169+
* @dataProvider providerUtilParseValue
11641170
*
11651171
* @return void
11661172
*/

0 commit comments

Comments
 (0)