BUG: use last __init__ to document class variables (#249)

* BUG: use last __init__ to document class variables

* BUG: add unit test for multiple __init__

* BUG: amend multiple __init__ test

Co-authored-by: Nicholas Coltharp <[email protected]>

Author: nosewings

pdoc/__init__.py

@@ -262,7 +262,8 @@ def _pep224_docstrings(doc_obj: Union['Module', 'Class'], *,
             tree = tree.body[0]  # ast.parse creates a dummy ast.Module wrapper
 
             # For classes, maybe add instance variables defined in __init__
-            for node in tree.body:
+            # Get the *last* __init__ node in case it is preceded by @overloads.
+            for node in reversed(tree.body):
                 if isinstance(node, ast.FunctionDef) and node.name == '__init__':
                     instance_vars, _ = _pep224_docstrings(doc_obj, _init_tree=node)
                     break

pdoc/test/__init__.py

@@ -889,22 +889,29 @@ def test_Variable_type_annotation_py36plus(self):
             filename = os.path.join(path, 'module36syntax.py')
             with open(filename, 'w') as f:
                 f.write('''
+from typing import overload
+
 var: str = 'x'
 """dummy"""
 
 class Foo:
     var: int = 3
     """dummy"""
 
-    def __init__(self):
-        self.var2: float = 1
-        """dummy"""
+    @overload
+    def __init__(self, var2: float):
+        pass
+
+    def __init__(self, var2):
+        self.var2: float = float(var2)
+        """dummy2"""
                 ''')
             mod = pdoc.Module(pdoc.import_module(filename))
             self.assertEqual(mod.doc['var'].type_annotation(), 'str')
             self.assertEqual(mod.doc['Foo'].doc['var'].type_annotation(), 'int')
             self.assertIsInstance(mod.doc['Foo'].doc['var2'], pdoc.Variable)
             self.assertEqual(mod.doc['Foo'].doc['var2'].type_annotation(), '')  # Won't fix
+            self.assertEqual(mod.doc['Foo'].doc['var2'].docstring, 'dummy2')
 
             self.assertIn('var: str', mod.text())
             self.assertIn('var: int', mod.text())