Skip to content

Migrate CI code coverage off nightly rust to stable #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpschorr opened this issue May 17, 2023 · 1 comment
Closed

Migrate CI code coverage off nightly rust to stable #364

jpschorr opened this issue May 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jpschorr
Copy link
Contributor

jpschorr commented May 17, 2023 •
edited
Loading

Cf. amazon-ion/ion-rust#538 :

Removes pin to nightly and removes the old -Zprofile runs and grcov based coverage generation in favor of -C source-instrumentation which is in stable.

This updates the CI to install llvm-tools-preview from rustup and install a nice wrapper for running source instrumentation called cargo-llvm-cov. We use this wrapper to generate codecov JSON to get region coverage since LCOV style output from source coverage in Rust/LLVM doesn't output branch coverage.
@jpschorr jpschorr added the enhancement New feature or request label May 17, 2023
@alancai98 alancai98 mentioned this issue Jun 2, 2023
Merged
@alancai98
Copy link
Member

Closed by #383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpschorr @alancai98