Skip to content

GridFS fails with enableSchemaHooks is not supported #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
dblythy opened this issue Mar 8, 2023 · 9 comments · Fixed by #8467
Closed
4 tasks done

GridFS fails with enableSchemaHooks is not supported #8466

dblythy opened this issue Mar 8, 2023 · 9 comments · Fixed by #8467
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@dblythy
Copy link
Member

dblythy commented Mar 8, 2023

New Issue Checklist

Issue Description

As mongoOptions are now set to Parse Server's default options, enableSchemaHooks can be passed to the GridFSAdapter

Steps to reproduce

  • Start Parse Server on alpha
  • Attempt to save a file

Actual Outcome

  • Rejected

Expected Outcome

  • Should resolve

Environment

Server

  • Parse Server version: alpha
  • Operating system: FILL_THIS_OUT
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): FILL_THIS_OUT

Database

  • System (MongoDB or Postgres): FILL_THIS_OUT
  • Database version: FILL_THIS_OUT
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): FILL_THIS_OUT

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): FILL_THIS_OUT
  • SDK version: FILL_THIS_OUT

Logs

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your issue will be closed. If a field does not apply to the issue, fill in n/a.

@omairvaiyani
Copy link
Contributor

@dblythy We noticed this issue yesterday, I've opened a PR to address it

@mtrezza
Copy link
Member

mtrezza commented Mar 8, 2023

Does this issue only exist on the alpha branch or also on beta or release? Do we know which PR introduced this bug?

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Mar 8, 2023
@dblythy
Copy link
Member Author

dblythy commented Mar 9, 2023

I would say it was introduced by #8436, as that PR set the default for enableSchemaHooks. So alpha only for if enableSchemaHooks is unset.

However, if the feature enableSchemaHooks is set to true from Parse Server 5 to alpha, GridFS will fail. Introduced by #7214

@mtrezza
Copy link
Member

mtrezza commented Mar 9, 2023

Interesting that we don't have any test coverage that picked that up. Ok so since this is a fix that also applies to stable releases this should be a fix commit type. We just need to name the PR in a way that reflects that broad scope.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.12

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 19, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
4 participants