Skip to content

Commit 239d141

Browse files
utils/dependency_cross_matcher.py: Print error info
* Print error information on the dependency mismatch checker instead of doing so in the ci.sh script. This simplifies the logic and reduces maintainability efforts. Signed-off-by: Tomás González <[email protected]>
1 parent 84b258e commit 239d141

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

tests/ci.sh

-5
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ done
3535
#########################
3636
if [ "$MISMATCHER" = "True" ]; then
3737
python3 $(pwd)/utils/dependency_cross_matcher.py --deps_dir $(pwd)
38-
mismatcher_result=$?
39-
if [ "$mismatcher_result" -ne 0 ]; then
40-
error_msg "Found dependencies version mismatches"
41-
fi
42-
4338
exit 0
4439
fi
4540

utils/dependency_cross_matcher.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ def main(argv=[], prog_name=''):
5454

5555
mismatches = get_deps_with_more_than_1v(mismatches)
5656

57+
print('---------------------exceptions-----------------------\n\n')
58+
print_deps(exceptions)
59+
5760
print('---------------------mistmatches----------------------\n\n')
5861
print_deps(mismatches)
5962

@@ -65,8 +68,7 @@ def main(argv=[], prog_name=''):
6568
'yasna': ['v0.4.0', 'v0.5.2'],
6669
}
6770

68-
if exceptions != mismatches:
69-
return 1
71+
assert exceptions == mismatches, "Found dependencies version mismatches in parsec-tool"
7072

7173
return 0
7274

0 commit comments

Comments
 (0)