Add regression test for Seldaek#691 and optimize implementation using a single pass loop over the handlers, refs Seldaek#692

Author: Seldaek

Diff for: src/Monolog/Logger.php

@@ -280,11 +280,14 @@ public function addRecord($level, $message, array $context = array())
 
         // check if any handler will handle this message so we can return early and save cycles
         $handlerKey = null;
-        foreach ($this->handlers as $key => $handler) {
+        reset($this->handlers);
+        while ($handler = current($this->handlers)) {
             if ($handler->isHandling(array('level' => $level))) {
-                $handlerKey = $key;
+                $handlerKey = key($this->handlers);
                 break;
             }
+
+            next($this->handlers);
         }
 
         if (null === $handlerKey) {
@@ -315,17 +318,13 @@ public function addRecord($level, $message, array $context = array())
         foreach ($this->processors as $processor) {
             $record = call_user_func($processor, $record);
         }
-        $foundStartingKey = false;
-        foreach ($this->handlers as $key => $handler) {
-            if ($key === $handlerKey) {
-                $foundStartingKey = true;
-            }
-            if ($foundStartingKey === false) {
-                continue;
-            }
+
+        while ($handler = current($this->handlers)) {
             if (true === $handler->handle($record)) {
                 break;
             }
+
+            next($this->handlers);
         }
 
         return true;

Diff for: tests/Monolog/LoggerTest.php

@@ -303,6 +303,45 @@ public function testHandlersNotCalledBeforeFirstHandling()
         $logger->debug('test');
     }
 
+    /**
+     * @covers Monolog\Logger::addRecord
+     */
+    public function testHandlersNotCalledBeforeFirstHandlingWithAssocArray()
+    {
+        $handler1 = $this->getMock('Monolog\Handler\HandlerInterface');
+        $handler1->expects($this->never())
+            ->method('isHandling')
+            ->will($this->returnValue(false))
+        ;
+        $handler1->expects($this->once())
+            ->method('handle')
+            ->will($this->returnValue(false))
+        ;
+
+        $handler2 = $this->getMock('Monolog\Handler\HandlerInterface');
+        $handler2->expects($this->once())
+            ->method('isHandling')
+            ->will($this->returnValue(true))
+        ;
+        $handler2->expects($this->once())
+            ->method('handle')
+            ->will($this->returnValue(false))
+        ;
+
+        $handler3 = $this->getMock('Monolog\Handler\HandlerInterface');
+        $handler3->expects($this->once())
+            ->method('isHandling')
+            ->will($this->returnValue(false))
+        ;
+        $handler3->expects($this->never())
+            ->method('handle')
+        ;
+
+        $logger = new Logger(__METHOD__, array('last' => $handler3, 'second' => $handler2, 'first' => $handler1));
+
+        $logger->debug('test');
+    }
+
     /**
      * @covers Monolog\Logger::addRecord
      */