perf(payload): move parent_header in PayloadBuilderStack::build_empty_payload #19995
+5
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes two unnecessary Arc clones of the parent header in PayloadBuilderStack::build_empty_payload by destructuring the owned PayloadConfig and moving parent_header directly into the branch-specific PayloadConfig. Since PayloadConfig::parent_header is an Arc<SealedHeader<...>> and the function takes config by value, cloning the Arc only increments and later decrements the refcount without any semantic benefit. The refactoring preserves behavior and type safety, as the impl requires both sides to share the same Primitives, ensuring the header type matches between branches. The result is slightly reduced refcount churn with no API changes or logic alterations.