CLN: assorted (#41816)

Author: jbrockmendel

pandas/core/arrays/datetimelike.py

@@ -1677,11 +1677,6 @@ class TimelikeOps(DatetimeLikeArrayMixin):
     Common ops for TimedeltaIndex/DatetimeIndex, but not PeriodIndex.
     """
 
-    def copy(self: TimelikeOpsT) -> TimelikeOpsT:
-        result = super().copy()
-        result._freq = self._freq
-        return result
-
     def _round(self, freq, mode, ambiguous, nonexistent):
         # round the local times
         if is_datetime64tz_dtype(self.dtype):

pandas/core/construction.py

@@ -556,7 +556,6 @@ def sanitize_array(
         if dtype is not None or len(data) == 0:
             subarr = _try_cast(data, dtype, copy, raise_cast_failure)
         else:
-            # TODO: copy?
             subarr = maybe_convert_platform(data)
             if subarr.dtype == object:
                 subarr = cast(np.ndarray, subarr)

pandas/core/dtypes/dtypes.py

@@ -89,12 +89,6 @@ class PandasExtensionDtype(ExtensionDtype):
     isnative = 0
     _cache_dtypes: dict[str_type, PandasExtensionDtype] = {}
 
-    def __str__(self) -> str_type:
-        """
-        Return a string representation for a particular Object
-        """
-        return self.name
-
     def __repr__(self) -> str_type:
         """
         Return a string representation for a particular object.

pandas/core/generic.py

@@ -10176,7 +10176,9 @@ def pct_change(
             assert _data is not None  # needed for mypy
             data = _data
 
-        rs = data.div(data.shift(periods=periods, freq=freq, axis=axis, **kwargs)) - 1
+        shifted = data.shift(periods=periods, freq=freq, axis=axis, **kwargs)
+        # Unsupported left operand type for / ("FrameOrSeries")
+        rs = data / shifted - 1  # type: ignore[operator]
         if freq is not None:
             # Shift method is implemented differently when freq is not None
             # We want to restore the original index

pandas/core/indexes/base.py

@@ -360,9 +360,6 @@ def _outer_indexer(
     _can_hold_na: bool = True
     _can_hold_strings: bool = True
 
-    # would we like our indexing holder to defer to us
-    _defer_to_indexing = False
-
     _engine_type: type[libindex.IndexEngine] = libindex.ObjectEngine
     # whether we support partial string indexing. Overridden
     # in DatetimeIndex and PeriodIndex

pandas/core/indexes/datetimes.py

@@ -323,10 +323,7 @@ def __new__(
     ) -> DatetimeIndex:
 
         if is_scalar(data):
-            raise TypeError(
-                f"{cls.__name__}() must be called with a "
-                f"collection of some kind, {repr(data)} was passed"
-            )
+            raise cls._scalar_data_error(data)
 
         # - Cases checked above all return/raise before reaching here - #
 

pandas/core/indexes/interval.py

@@ -258,9 +258,6 @@ class IntervalIndex(ExtensionIndex):
     closed_left: bool
     closed_right: bool
 
-    # we would like our indexing holder to defer to us
-    _defer_to_indexing = True
-
     _data: IntervalArray
     _values: IntervalArray
     _can_hold_strings = False

pandas/core/indexes/multi.py

@@ -2813,7 +2813,7 @@ def slice_locs(self, start=None, end=None, step=None, kind=None):
         # happens in get_slice_bound method), but it adds meaningful doc.
         return super().slice_locs(start, end, step)
 
-    def _partial_tup_index(self, tup, side="left"):
+    def _partial_tup_index(self, tup: tuple, side="left"):
         if len(tup) > self._lexsort_depth:
             raise UnsortedIndexError(
                 f"Key length ({len(tup)}) was greater than MultiIndex lexsort depth "

pandas/core/indexes/timedeltas.py

@@ -130,10 +130,7 @@ def __new__(
         name = maybe_extract_name(name, data, cls)
 
         if is_scalar(data):
-            raise TypeError(
-                f"{cls.__name__}() must be called with a "
-                f"collection of some kind, {repr(data)} was passed"
-            )
+            raise cls._scalar_data_error(data)
 
         if unit in {"Y", "y", "M"}:
             raise ValueError(

pandas/tests/indexes/datetimes/test_constructors.py

@@ -552,7 +552,7 @@ def test_constructor_coverage(self):
         with pytest.raises(TypeError, match=msg):
             date_range(start="1/1/2000", periods="foo", freq="D")
 
-        msg = "DatetimeIndex\\(\\) must be called with a collection"
+        msg = r"DatetimeIndex\(\.\.\.\) must be called with a collection"
         with pytest.raises(TypeError, match=msg):
             DatetimeIndex("1/1/2000")