Feat/multi quoter not isolation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
reviewed
Nov 29, 2024
ChefMist
previously approved these changes
Nov 29, 2024
ChefMist
approved these changes
Nov 29, 2024
chefburger
reviewed
Dec 2, 2024
| MixedQuoterRecorder.getPoolSwapTokenAccumulation(poolHash, zeroForOne); | ||
| uint256 swapAmountOut; | ||
| amountIn += accAmountIn; | ||
| (swapAmountOut, gasEstimateForCurAction) = quoteExactInputSingleStable( |
There was a problem hiding this comment.
do we need to have "quote*WithAccumulation" version for ss pool as well ? Not familiar with it's charging rule, does the fee also auto get reinvested into the pool ?
There was a problem hiding this comment.
should not need.
it is different from v2.
chefburger
reviewed
Dec 2, 2024
| /// @param key The pool key. | ||
| /// @return poolHash The hash of the pool. | ||
| function getV4CLPoolHash(PoolKey memory key) internal pure returns (bytes32) { | ||
| return keccak256(abi.encode(key, SWAP_V4_CL)); |
There was a problem hiding this comment.
curious, why not directly key.toId() here ?
There was a problem hiding this comment.
no special reason, just do not want to confuse , and keep same style with other pools
chefburger
approved these changes
Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All swap results will influence the outcome of subsequent swaps within the same pool