internal s23: set bytecode_hash = zero (#59)

* test: add size snapshot before bytecode_hash=none

* internal s23: set bytecode_hash = zero

* test: add CLPositionDescriptorOffChainSize size

.forge-snapshots/CLPositionDescriptorOffChainSize.snap

@@ -0,0 +1 @@
+2568

foundry.toml

@@ -13,6 +13,7 @@ fs_permissions = [
     { access = "read", path = "./test/bin/" },
 ]
 evm_version = 'cancun'
+bytecode_hash = "none"
 
 [fuzz]
 runs = 1000 # change this for higher number of fuzz/invariant locally

test/pool-cl/CLPositionDescriptorOffChain.t.sol

@@ -2,6 +2,7 @@
 pragma solidity ^0.8.24;
 
 import {Test} from "forge-std/Test.sol";
+import {GasSnapshot} from "forge-gas-snapshot/GasSnapshot.sol";
 import {CLPositionDescriptorOffChain} from "../../src/pool-cl/CLPositionDescriptorOffChain.sol";
 import {ICLPositionManager} from "../../src/pool-cl/interfaces/ICLPositionManager.sol";
 import {Strings} from "@openzeppelin/contracts/utils/Strings.sol";
@@ -19,14 +20,26 @@ contract FakeTokenURIContract is ICLPositionDescriptor {
     }
 }
 
-contract CLPositionDescriptorOffChainTest is Test {
+contract CLPositionDescriptorOffChainTest is Test, GasSnapshot {
     CLPositionDescriptorOffChain clPositionDescriptorOffChain;
 
+    error ContractSizeTooLarge(uint256 diff);
+
     function setUp() public {
         clPositionDescriptorOffChain =
             new CLPositionDescriptorOffChain("https://pancakeswap.finance/v4/pool-cl/positions/");
     }
 
+    function test_bytecodeSize() public {
+        snapSize("CLPositionDescriptorOffChainSize", address(clPositionDescriptorOffChain));
+
+        // forge coverage will run with '--ir-minimum' which set optimizer run to min
+        // thus we do not want to revert for forge coverage case
+        if (vm.envExists("FOUNDRY_PROFILE") && address(clPositionDescriptorOffChain).code.length > 24576) {
+            revert ContractSizeTooLarge(address(clPositionDescriptorOffChain).code.length - 24576);
+        }
+    }
+
     function testTokenURI() public view {
         // tokenId=1
         string memory tokenURI = clPositionDescriptorOffChain.tokenURI(ICLPositionManager(address(0)), 1);