Skip to content

Commit 5eb75c7

Browse files
committed
drop support for python 3.8
1 parent 8b89814 commit 5eb75c7

File tree

8 files changed

+9
-53
lines changed

8 files changed

+9
-53
lines changed

Diff for: .github/workflows/tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
python: ['3.12', '3.11', '3.10', '3.9', '3.8']
15+
python: ['3.12', '3.11', '3.10', '3.9']
1616
steps:
1717
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
1818
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0

Diff for: CHANGES.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
Unreleased
44

5+
- Drop support for Python 3.8.
56
- Support Flask-SQLAlchemy-Lite and plain SQLAlchemy, in addition to
67
Flask-SQLAlchemy. {pr}`26`
78
- Support multiple databases, and multiple metadata per database. {pr}`26`

Diff for: pyproject.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ classifiers = [
1616
"Topic :: Database",
1717
"Typing :: Typed",
1818
]
19-
requires-python = ">=3.8"
19+
requires-python = ">=3.9"
2020
dependencies = [
2121
"alembic>=1.13",
2222
"flask>=3.0",
@@ -47,14 +47,14 @@ source = ["flask_alembic", "tests"]
4747
source = ["src", "*/site-packages"]
4848

4949
[tool.mypy]
50-
python_version = "3.8"
50+
python_version = "3.9"
5151
files = ["src/flask_alembic", "tests"]
5252
show_error_codes = true
5353
pretty = true
5454
strict = true
5555

5656
[tool.pyright]
57-
pythonVersion = "3.8"
57+
pythonVersion = "3.9"
5858
include = ["src/flask_alembic", "tests"]
5959

6060
[tool.ruff]

Diff for: requirements/tests-3.8.in

-2
This file was deleted.

Diff for: requirements/tests-3.8.txt

-36
This file was deleted.

Diff for: tests/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
import pytest
88
from flask import Flask
99
from flask.ctx import AppContext
10-
from flask_sqlalchemy import SQLAlchemy
10+
from flask_sqlalchemy_lite import SQLAlchemy
1111

1212
from flask_alembic import Alembic
1313

1414

1515
@pytest.fixture
1616
def app(request: pytest.FixtureRequest, tmp_path: Path) -> Flask:
1717
app = Flask(request.module.__name__, root_path=os.fspath(tmp_path))
18-
app.config["SQLALCHEMY_BINDS"] = {
18+
app.config["SQLALCHEMY_ENGINES"] = {
1919
"default": "sqlite://",
2020
"other": "sqlite://",
2121
}

Diff for: tests/test_fsa_lite.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,12 @@
55

66
import pytest
77
from flask import Flask
8+
from flask_sqlalchemy_lite import SQLAlchemy
89
from sqlalchemy import create_engine
910
from sqlalchemy.orm import DeclarativeBase
1011

1112
from flask_alembic import Alembic
1213

13-
try:
14-
from flask_sqlalchemy_lite import SQLAlchemy
15-
except ImportError:
16-
pytest.skip("flask_sqlalchemy_lite not available", allow_module_level=True)
17-
1814

1915
@pytest.fixture
2016
def app(app: Flask) -> Flask:

Diff for: tox.ini

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tox]
22
envlist =
3-
py3{12,11,10,9,8}
3+
py3{12,11,10,9}
44
style
55
typing
66
docs
@@ -14,9 +14,6 @@ use_frozen_constraints = true
1414
deps = -r requirements/tests.txt
1515
commands = pytest -v --tb=short --basetemp={envtmpdir} {posargs}
1616

17-
[testenv:py38,py3.8]
18-
deps = -r requirements/tests-3.8.txt
19-
2017
[testenv:style]
2118
deps = pre-commit
2219
skip_install = true

0 commit comments

Comments
 (0)