SoftNpu early return on empty guest virtio buffers, bump dlpi crate, fix duplicate crate import issue (#274)

Author: rcgoodfellow

bin/propolis-standalone/src/main.rs

@@ -264,10 +264,9 @@ impl Instance {
             match state {
                 State::Run => {
                     if first_boot {
-                        ent.start().expect(&format!(
-                            "entity {} failed to start",
-                            record.name()
-                        ));
+                        ent.start().unwrap_or_else(|_| {
+                            panic!("entity {} failed to start", record.name())
+                        });
                     } else {
                         ent.resume();
                     }

crates/bhyve-api/header-check/Cargo.toml

@@ -4,6 +4,7 @@ version = "0.0.0"
 authors = ["Patrick Mooney <[email protected]>"]
 license = "MPL-2.0"
 build = "build.rs"
+publish = false
 
 [dependencies]
 bhyve_api = { path = ".." }

crates/viona-api/header-check/Cargo.toml

@@ -4,6 +4,7 @@ version = "0.0.0"
 authors = ["Patrick Mooney <[email protected]>"]
 license = "MPL-2.0"
 build = "build.rs"
+publish = false
 
 [dependencies]
 viona_api = { path = ".." }

lib/propolis/Cargo.toml

@@ -65,10 +65,9 @@ branch = "main"
 optional = true
 package = "softnpu"
 
-#see: https://github.com/oxidecomputer/dlpi-sys/issues/1
 [dependencies.dlpi]
 git = "https://github.com/oxidecomputer/dlpi-sys"
-rev = "eb4dffeef88f86294d939aeb5521509ea3d59b69"
+branch = "main"
 optional = true
 
 [dev-dependencies]

lib/propolis/src/hw/virtio/softnpu.rs

@@ -330,6 +330,8 @@ impl PciVirtioSoftNpuPort {
             if n != 10 {
                 if n > 0 {
                     push_used = true;
+                } else {
+                    break;
                 }
                 warn!(self.log, "failed to read virtio mystery bytes ({})", n);
                 //break;