Skip to content

Regression in nexus-db-queries test performance from user_data_export #8903

@smklein

Description

@smklein

While running the nexus-db-queries test suite, I'm noticing that the tests added in this PR have slowed down tests for that module by several minutes - they're the only SLOW tests labelled by nextest, where most other tests are completing in ~5 seconds or less.

        SLOW [> 60.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_create_large
        SLOW [> 60.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_delete_large
        SLOW [> 60.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_noop_large
        SLOW [> 60.000s] nexus-db-queries db::datastore::user_data_export::tests::test_delete_records_for_expunged_pantries
        PASS [ 100.380s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_create_large
        SLOW [>120.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_delete_large
        SLOW [>120.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_noop_large
        SLOW [>120.000s] nexus-db-queries db::datastore::user_data_export::tests::test_delete_records_for_expunged_pantries
        PASS [ 148.597s] nexus-db-queries db::datastore::user_data_export::tests::test_delete_records_for_expunged_pantries
        PASS [ 151.758s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_noop_large
        SLOW [>180.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_delete_large
        SLOW [>240.000s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_delete_large
        PASS [ 266.981s] nexus-db-queries db::datastore::user_data_export::tests::test_changeset_delete_large

I see that there are many tests here running in a loop for a LARGE_NUMBER_OF_ROWS - what is this aiming to test? Is it necessary to actually use an iteration of "3000x" to accomplish this?

Originally posted by @smklein in #8471 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions