more disciplined path handling

Author: steveklabnik

dropshot/src/logging.rs

@@ -440,17 +440,20 @@ mod test {
     #[test]
     fn test_config_bad_file_path_exists_fail() {
         let mut logtest = LogTest::setup("bad_file_path_exists_fail_dir");
-        let path = logtest.will_create_file("log.out");
-        fs::write(&path, "").expect("writing empty file");
+        let logpath = logtest.will_create_file("log.out");
+        fs::write(&logpath, "").expect("writing empty file");
+
+        // Windows paths need to have \ turned into \\
+        let escaped_path = logpath.display().to_string().escape_default().to_string();
 
         let bad_config = format!(
             r#"
             mode = "file"
             level = "warn"
             if_exists = "fail"
-            path = {:?}
+            path = "{}"
             "#,
-            path
+            escaped_path
         );
 
         let error = read_config_and_create_logger(
@@ -474,15 +477,18 @@ mod test {
         let logpath = logtest.will_create_file("log.out");
         let time_before = chrono::offset::Utc::now();
 
+        // Windows paths need to have \ turned into \\
+        let escaped_path = logpath.display().to_string().escape_default().to_string();
+
         /* The first attempt should succeed.  The log file doesn't exist yet. */
         let config = format!(
             r#"
             mode = "file"
             level = "warn"
             if_exists = "fail"
-            path = {:?}
+            path = "{}"
             "#,
-            &logpath
+            escaped_path
         );
 
         {
@@ -502,9 +508,9 @@ mod test {
             mode = "file"
             level = "warn"
             if_exists = "append"
-            path = {:?}
+            path = "{}"
             "#,
-            &logpath
+            escaped_path
         );
 
         {
@@ -544,9 +550,9 @@ mod test {
             mode = "file"
             level = "trace"
             if_exists = "truncate"
-            path = {:?}
+            path = "{}"
             "#,
-            &logpath
+            escaped_path
         );
 
         {