Skip to content

Commit fd10990

Browse files
committed
Remove misfiring IP address presence check.
This check assumed that IP addresses are only given for debugging with NetCore, but since @hawkw's improvements recently, that is no longer the case. Now, this check is actually preventing anyone from using the gimlet subcommand, which is a Detached command. I glanced over the commands that use this, and I don't think this check is pulling its weight -- I don't think it's worth introducing another piece of command metadata to specify "I'm detached but also I'd like an IP address." So, I've removed it.
1 parent 64968ed commit fd10990

File tree

5 files changed

+6
-10
lines changed

5 files changed

+6
-10
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ name = "humility"
1717
#
1818
# Be sure to check in and push all of the files that change. Happy versioning!
1919
#
20-
version = "0.10.38"
20+
version = "0.10.39"
2121
authors = ["Bryan Cantrill <[email protected]>"]
2222
edition = "2018"
2323
license = "MPL-2.0"

src/cmd.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,6 @@ pub fn subcommand(
106106
bail!("cannot specify a dump for {} command", cmd);
107107
}
108108

109-
if context.cli.ip.is_some() {
110-
bail!("cannot specify IP address for {} command", cmd);
111-
}
112-
113109
if context.cli.probe.is_some() {
114110
bail!("cannot specify probe for {} command", cmd);
115111
}

tests/cmd/chip.trycmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ For more information try --help
1313

1414
```
1515
$ humility --chip this-can-be-anything -V
16-
humility 0.10.38
16+
humility 0.10.39
1717

1818
```
1919

@@ -28,7 +28,7 @@ For more information try --help
2828

2929
```
3030
$ humility -c apx432 -V
31-
humility 0.10.38
31+
humility 0.10.39
3232

3333
```
3434

tests/cmd/version.trycmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ Long version flag:
22

33
```
44
$ humility --version
5-
humility 0.10.38
5+
humility 0.10.39
66

77
```
88

99
Short version flag:
1010

1111
```
1212
$ humility -V
13-
humility 0.10.38
13+
humility 0.10.39
1414

1515
```

0 commit comments

Comments
 (0)