Skip to content

Commit 7c9388f

Browse files
committed
test(tsconfig): tweak jsx extends tests (#666)
1 parent 107d406 commit 7c9388f

File tree

4 files changed

+10
-34
lines changed

4 files changed

+10
-34
lines changed

fixtures/tsconfig/cases/extends-jsx/base-tsconfig.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

fixtures/tsconfig/cases/extends-jsx/tsconfig.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

fixtures/tsconfig/cases/extends/base-tsconfig.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
"allowJs": true,
55
"emitDecoratorMetadata": true,
66
"useDefineForClassFields": true,
7-
"rewriteRelativeImportExtensions": true
7+
"rewriteRelativeImportExtensions": true,
8+
"jsx": "react-jsx",
9+
"jsxFactory": "React.createElement",
10+
"jsxFragmentFactory": "React.Fragment",
11+
"jsxImportSource": "react"
812
},
913
"files": ["files"],
1014
"include": ["include"],

src/tests/tsconfig_extends.rs

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ fn test_extend_tsconfig() {
3232
assert_eq!(compiler_options.emit_decorator_metadata, Some(true));
3333
assert_eq!(compiler_options.use_define_for_class_fields, Some(true));
3434
assert_eq!(compiler_options.rewrite_relative_import_extensions, Some(true));
35+
36+
assert_eq!(compiler_options.jsx, Some("react-jsx".to_string()));
37+
assert_eq!(compiler_options.jsx_factory, Some("React.createElement".to_string()));
38+
assert_eq!(compiler_options.jsx_fragment_factory, Some("React.Fragment".to_string()));
39+
assert_eq!(compiler_options.jsx_import_source, Some("react".to_string()));
3540
}
3641

3742
#[test]
@@ -72,28 +77,6 @@ fn test_extend_tsconfig_override_behavior() {
7277
assert_eq!(compiler_options.target, Some("ES2020".to_string()));
7378
}
7479

75-
#[test]
76-
fn test_extend_tsconfig_jsx_options() {
77-
let f = super::fixture_root().join("tsconfig/cases/extends-jsx");
78-
79-
let resolver = Resolver::new(ResolveOptions {
80-
tsconfig: Some(TsconfigOptions {
81-
config_file: f.join("tsconfig.json"),
82-
references: TsconfigReferences::Auto,
83-
}),
84-
..ResolveOptions::default()
85-
});
86-
87-
let resolution = resolver.resolve_tsconfig(&f).expect("resolved");
88-
let compiler_options = resolution.compiler_options();
89-
90-
// Should inherit all JSX-related options
91-
assert_eq!(compiler_options.jsx, Some("react-jsx".to_string()));
92-
assert_eq!(compiler_options.jsx_factory, Some("React.createElement".to_string()));
93-
assert_eq!(compiler_options.jsx_fragment_factory, Some("React.Fragment".to_string()));
94-
assert_eq!(compiler_options.jsx_import_source, Some("react".to_string()));
95-
}
96-
9780
#[test]
9881
fn test_extend_tsconfig_template_variables() {
9982
let f = super::fixture_root().join("tsconfig/cases/extends-template-vars");

0 commit comments

Comments
 (0)