Skip to content

Commit 18378c1

Browse files
committed
Removed unnecessary dynamic_casts
1 parent a23e88f commit 18378c1

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/rule_with_actions.cc

+6-8
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ void RuleWithActions::executeActionsIndependentOfChainedRuleResult(Transaction *
213213
if (m_ruleId != b.first) {
214214
continue;
215215
}
216-
actions::Action *a = dynamic_cast<actions::Action*>(b.second.get());
216+
actions::Action *a = b.second.get();
217217
if (a->isDisruptive() == true && *a->m_name.get() == "block") {
218218
ms_dbg_a(trans, 9, "Rule contains a `block' action");
219219
*containsBlock = true;
@@ -266,7 +266,7 @@ void RuleWithActions::executeActionsAfterFullMatch(Transaction *trans,
266266
if (m_ruleId != b.first) {
267267
continue;
268268
}
269-
actions::Action *a = dynamic_cast<actions::Action*>(b.second.get());
269+
actions::Action *a = b.second.get();
270270
executeAction(trans, containsBlock, ruleMessage, a, false);
271271
disruptiveAlreadyExecuted = true;
272272
}
@@ -394,8 +394,7 @@ void RuleWithActions::executeTransformations(
394394

395395
for (Transformation *a : m_transformations) {
396396
if (none == 0) {
397-
Transformation *t = dynamic_cast<Transformation *>(a);
398-
executeTransformation(t, &value, trans, &ret, &path,
397+
executeTransformation(a, &value, trans, &ret, &path,
399398
&transformations);
400399
}
401400
if (a->m_isNone) {
@@ -423,8 +422,7 @@ void RuleWithActions::executeTransformations(
423422
}
424423
Transformation *a = dynamic_cast<Transformation*>(b.second.get());
425424
if (none == 0) {
426-
Transformation *t = dynamic_cast<Transformation *>(a);
427-
executeTransformation(t, &value, trans, &ret, &path,
425+
executeTransformation(a, &value, trans, &ret, &path,
428426
&transformations);
429427
}
430428
if (a->m_isNone) {
@@ -479,7 +477,7 @@ std::vector<actions::Action *> RuleWithActions::getActionsByName(const std::stri
479477
if (m_ruleId != b.first) {
480478
continue;
481479
}
482-
actions::Action *z = dynamic_cast<actions::Action*>(b.second.get());
480+
actions::Action *z = b.second.get();
483481
if (*z->m_name.get() == name) {
484482
ret.push_back(z);
485483
}
@@ -489,7 +487,7 @@ std::vector<actions::Action *> RuleWithActions::getActionsByName(const std::stri
489487
if (m_ruleId != b.first) {
490488
continue;
491489
}
492-
actions::Action *z = dynamic_cast<actions::Action*>(b.second.get());
490+
actions::Action *z = b.second.get();
493491
if (*z->m_name.get() == name) {
494492
ret.push_back(z);
495493
}

0 commit comments

Comments
 (0)