Fix 404s (#802)

Author: eversC

go.mod

@@ -14,7 +14,7 @@ require (
 	github.com/google/go-github/v45 v45.2.0
 	github.com/jszwedko/go-circleci v0.3.0
 	github.com/mongodb/go-client-mongodb-atlas v0.3.0
-	github.com/ovotech/cloud-key-client v0.4.1
+	github.com/ovotech/cloud-key-client v0.4.2
 	github.com/ovotech/mantle v0.32.3
 	github.com/spf13/cobra v1.6.1
 	github.com/spf13/viper v1.15.0

go.sum

@@ -345,6 +345,8 @@ github.com/openlyinc/pointy v1.1.2 h1:LywVV2BWC5Sp5v7FoP4bUD+2Yn5k0VNeRbU5vq9jUM
 github.com/openlyinc/pointy v1.1.2/go.mod h1:w2Sytx+0FVuMKn37xpXIAyBNhFNBIJGR/v2m7ik1WtM=
 github.com/ovotech/cloud-key-client v0.4.1 h1:88WT3iJKX1hs9KKyP+hCUxnFkeor15xBaPaLD/MP1h4=
 github.com/ovotech/cloud-key-client v0.4.1/go.mod h1:GE+dvpLfk42JW0jX2Hzs8Gocjj4vWlliZTIq9W2Z0Ns=
+github.com/ovotech/cloud-key-client v0.4.2 h1:NpHyTqBTyQV7uvJlcbCB1rgFhyRMHUZq82zV3/l2Gu4=
+github.com/ovotech/cloud-key-client v0.4.2/go.mod h1:GE+dvpLfk42JW0jX2Hzs8Gocjj4vWlliZTIq9W2Z0Ns=
 github.com/ovotech/mantle v0.32.3 h1:LNqEYlotYhbxcDIrU476c3B+vhAQ92kdCjeNdbaZxjU=
 github.com/ovotech/mantle v0.32.3/go.mod h1:bSrueYEoP2Tt3DMrXvSsia+WLM7tv5C2nc1Rdi0Mrh4=
 github.com/pelletier/go-buffruneio v0.2.0/go.mod h1:JkE26KsDizTr40EUHkXVtNPvgGtbSNq5BcowyYOWdKo=

pkg/location/github.go

@@ -5,7 +5,7 @@ import (
 	crypto_rand "crypto/rand"
 	"encoding/base64"
 	"fmt"
-	"strings"
+	"net/url"
 
 	"github.com/ovotech/cloud-key-rotator/pkg/cred"
 
@@ -65,7 +65,7 @@ func (github GitHub) Write(serviceAccountName string, keyWrapper KeyWrapper, cre
 	repo, _, err := client.Repositories.Get(ctx, github.Owner, github.Repo)
 	repoID := repo.GetID()
 	// encode forwardslash character (which is valid in GitHub environment names), otherwise it'll break a REST API call
-	env := strings.Replace(github.Env, "/", "%2F", -1)
+	env := url.PathEscape(github.Env)
 
 	if len(keyIDEnvVar) > 0 {
 		if err = addEnvOrRepoSecret(ctx, actionsService, github.Owner, github.Repo, env, keyIDEnvVar, keyWrapper.KeyID, repoID); err != nil {