Skip to content

Commit 7849eb2

Browse files
simonartxaviernumansiddique
authored andcommitted
tests: Fix "interconnection" ic test.
This test started recently [1] to become flaky (since remote ports are related ports). Note that the test should in fact always fail (and not only randomly), but due to some (independent) issues in CHECK_RELATED_PORTS_AFTER_RECOMPUTE this is not always visible. The CHECK_RELATED_PORTS_AFTER_RECOMPUTE macro issue will be fixed separately. [1] ba2db3b ("northd: Fix broadcast of all traffic within a transit spine switch.") Fixes: ba2db3b ("northd: Fix broadcast of all traffic within a transit spine switch.") Signed-off-by: Xavier Simonart <[email protected]> Signed-off-by: Numan Siddique <[email protected]>
1 parent 0f324ce commit 7849eb2

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

tests/ovn-ic.at

+17-1
Original file line numberDiff line numberDiff line change
@@ -1721,8 +1721,24 @@ for s_az in $(seq 1 $n_az); do
17211721
done
17221722
OVS_WAIT_UNTIL([check_packets], [$at_diff -F'^---' expected received])
17231723

1724+
# ts[i] become local datapaths in hv[az] right before we lrp-set the
1725+
# gateway-chassis on lrp-lr$az-$i-ts$i.
1726+
# For ts1 & ts2, there are recomputes after the gateway-chassis has been set
1727+
# (e.g. when some tunnel_keys get added), and hence they get removed from
1728+
# local datapaths.
1729+
# However this is not the case for ts3: there is no recompute, and local
1730+
# datapaths are usually not removed in I+P. Ignore this.
1731+
# Also, ts3 remaining a local datapath, and lsp-ts3-lr[x]-3 being remote port, it
1732+
# is a related port. Ignore this also
1733+
ovn_as az1 OVN_CLEANUP_SBOX([hv1], [], ["lsp-ts3-lr2-3
1734+
lsp-ts3-lr3-3"], [ts3])
1735+
ovn_as az2 OVN_CLEANUP_SBOX([hv2], [], ["lsp-ts3-lr1-3
1736+
lsp-ts3-lr3-3"], [ts3])
1737+
ovn_as az3 OVN_CLEANUP_SBOX([hv3], [], ["lsp-ts3-lr1-3
1738+
lsp-ts3-lr2-3"], [ts3])
1739+
17241740
for az in `seq 1 $n_az`; do
1725-
OVN_CLEANUP_SBOX([hv$az])
1741+
ovn_as az$az
17261742
OVN_CLEANUP_SBOX([gw$az])
17271743
OVN_CLEANUP_AZ([az$az])
17281744
done

0 commit comments

Comments
 (0)