From 63de413b8d8687700587f24d787e59cbc43e1007 Mon Sep 17 00:00:00 2001 From: Dumitru Ceara Date: Wed, 22 Jan 2025 09:41:34 +0100 Subject: [PATCH] tests: Add missing reset_pcap_file() definition to EDNS test. When backporting f22a1ba9c127 ("Skip only OVN DNS responder packets from OUT_ACL.") we missed the fact that on branch-22.03 reset_pcap_file() had not been factored out as a standalone helper. That is, commit 8f841ecbe28e ("tests: Factor out reset_pcap_file() helper.") is missing on branch 22.03. For simplicity, adapt the EDNS test to include its own definition of the helper (similar to other tests on the 22.03 branch). Fixes: f22a1ba9c127 ("Skip only OVN DNS responder packets from OUT_ACL.") Signed-off-by: Dumitru Ceara Acked-by: Mark Michelson --- tests/ovn.at | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 2fb8519959..4649d733ad 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -10904,6 +10904,16 @@ OVN_POPULATE_ARP wait_for_ports_up check ovn-nbctl --wait=hv sync +reset_pcap_file() { + local iface=$1 + local pcap_file=$2 + check ovs-vsctl -- set Interface $iface options:tx_pcap=dummy-tx.pcap \ +options:rxq_pcap=dummy-rx.pcap + rm -f ${pcap_file}*.pcap + check ovs-vsctl -- set Interface $iface options:tx_pcap=${pcap_file}-tx.pcap \ +options:rxq_pcap=${pcap_file}-rx.pcap +} + dns_req=$(fmt_pkt "Ether(dst='00:00:00:00:00:02', src='00:00:00:00:00:01') / \ IP(dst='10.0.0.254', src='10.0.0.1') / \ UDP(sport=42424, dport=53) / \