Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions throw and not return Exceptions #4

Open
panvid opened this issue Jul 12, 2018 · 1 comment
Open

Functions throw and not return Exceptions #4

panvid opened this issue Jul 12, 2018 · 1 comment

Comments

@panvid
Copy link

panvid commented Jul 12, 2018

The library functions, like get, has the information, that they return array or an Exception. Exceptions are not returned but thrown.

It would be nice if the PhpDoc says

@throws \GuzzleHttp\Exception\BadResponseException
@ouqiang
Copy link
Owner

ouqiang commented Jul 22, 2018

It has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panvid @ouqiang