Skip to content

Commit 4192d9a

Browse files
committed
WHIP: X509 cert serial number should be positive.
1 parent 4aa17ba commit 4192d9a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

libavformat/tls_openssl.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri
316316
goto enomem_end;
317317
}
318318

319-
serial = (int)av_get_random_seed();
319+
// The serial number MUST be a positive integer。
320+
serial = (int)(av_get_random_seed() & 0x7FFFFFFF);
320321
if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) {
321322
av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL));
322323
goto einval_end;

0 commit comments

Comments
 (0)