chore(yarn): Prefer also over let if the return value is not used

sschuberth · sschuberth · commit 90ec14e23c98 · 2025-01-24T20:13:13.000+01:00
Signed-off-by: Sebastian Schuberth &lt;sebastian@doubleopen.org&gt;
diff --git a/plugins/package-managers/node/src/main/kotlin/yarn/Yarn.kt b/plugins/package-managers/node/src/main/kotlin/yarn/Yarn.kt
@@ -255,7 +255,7 @@ open class Yarn(
                     projectDirs,
                     ancestorModuleDirs = dependencyModuleDirPath.subList(1, dependencyModuleDirPath.size),
                     ancestorModuleIds = ancestorModuleIds + moduleId
-                )?.let { dependencies += it }
+                )?.also { dependencies += it }
 
                 return@forEach
             }
@@ -345,7 +345,7 @@ open class Yarn(
     }
 
     internal fun getRemotePackageDetails(packageName: String): PackageJson? {
-        yarnInfoCache.read(packageName)?.let { return parsePackageJson(it) }
+        yarnInfoCache.read(packageName)?.also { return parsePackageJson(it) }
 
         val process = YarnCommand.run("info", "--json", packageName).requireSuccess()
 

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ open class Yarn(`
`255`	`255`	`projectDirs,`
`256`	`256`	`ancestorModuleDirs = dependencyModuleDirPath.subList(1, dependencyModuleDirPath.size),`
`257`	`257`	`ancestorModuleIds = ancestorModuleIds + moduleId`
`258`		`- )?.let { dependencies += it }`
	`258`	`+ )?.also { dependencies += it }`
`259`	`259`
`260`	`260`	`return@forEach`
`261`	`261`	`}`
`@@ -345,7 +345,7 @@ open class Yarn(`
`345`	`345`	`}`
`346`	`346`
`347`	`347`	`internal fun getRemotePackageDetails(packageName: String): PackageJson? {`
`348`		`- yarnInfoCache.read(packageName)?.let { return parsePackageJson(it) }`
	`348`	`+ yarnInfoCache.read(packageName)?.also { return parsePackageJson(it) }`
`349`	`349`
`350`	`350`	`val process = YarnCommand.run("info", "--json", packageName).requireSuccess()`
`351`	`351`