-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script to generate maps with less manual effort #25
Comments
@mikedld I'm curious: Is it possible to see a map section in Portugal that you created with your script (without having to set everything up myself)? What was your impression - does the rendering work reasonably well? How did you handle the highway areas and street parking? Do you have reasonable data in your locations? |
Here're 2 out of 3 renders that are configured via config.json in that generator repo of mine (3rd one, Lisboa, is huge and takes quite some time to process and render):
(links above will expire in 7 days, don't want to draw much traffic to my server) I (together with @waldyrious) was slightly surprized that tertiary/secondary/primary highways weren't rendered at all w/o tagging areas with Certainly there're things that I'd improve, that is if I understood how it actually works internally and had an Idea of how easy/hard it would be. My thoughts aren't at all structured on this at the moment. |
These are super cool to see! Very useful to compare with osm2streets and looks for bugs / things this map does better. I'd definitely be interested in using your script to generate more areas for comparison. |
Oh, interesting to see that the major road lines (primary, secondary etc.) are not rendered at all. I don't think the issue is on your side. Since the Straßenraumkarte was initially a purely local project to generate a background map for Neukölln (with a focus on highway areas) and I partly used an external carriageway area data set here, there was initially no need to render them at all. But I will fix that when I get the chance. I have been planning for some time to create "backup" road areas from highway lines in areas without area:highway. However, I would like to technically modernize the map in the future, for example by using a postgres database with any osm/pbf files. So it may take a while yet...
This is probably due to faults in the processing of separate parking areas in some cases. These areas are converted into lines for rendering in a complex process and in some cases no line can be generated. Where the vehicles are missing, there is probably a missing geometry in the street_parking geojson. In Neukölln, we use manually post-processed street parking data (especially snapped to curbs). During this manual adjustment, incorrect data at intersections can also be corrected. The script cuts out parking spaces within a radius of 5 meters around the intersection points of virtual curb lines deduced from the highway width - in places like here, however, the virtual intersection points are inside the actual intersection. junction areas are not taken into account during this trimming, as sometimes there can also be parking spaces in intersections, e.g. often at T-intersections.
At first glance, I can't see why no cycle path crossing is rendered at this location (https://www.openstreetmap.org/way/1056779298). In post-processing there is a special treatment of such cycle path segments, so there should be line segments for this cycle path in "post_processed/cycleways.geojson". Perhaps this is where it fails. The rendering then checks for "cycleway=crossing" and "crossing:markings=dashes" (or crossing=traffic_signals/marked), which is tagged correct here... All in all, however, I am surprised that the rendering works quite well, especially in Encarnação, since for a "perfect" result some very special tags/mappings are required (as you described for the position of the center lines, for example). But there are only a few places where crazy things happen in Portugal :) |
Here's the third render (Lisboa): https://cl.gy/fXrTR I had to disable water bodies post-processing as it fails (probably due to unclosed areas or something like that; don't remember the exact error), and forest trees rendering which fails on tiles generation (memory allocation failures and some other random errors, even with a step of 1, seemingly unconnected to the amount of RAM I have which is 64 GiB, more like defects in QGIS or Qt or something else). |
Originally posted by @mikedld in #9 (comment)
The text was updated successfully, but these errors were encountered: