Merge pull request JuliaArrays#91 from piever/pv/test

Minor cleanup

Author: Pietro Vertechi

Project.toml

@@ -13,9 +13,7 @@ julia = "1"
 
 [extras]
 OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
-Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
-WeakRefStrings = "ea10d353-3f73-51f8-a26c-33c1cb351aa5"
 
 [targets]
-test = ["Test", "OffsetArrays", "Tables", "WeakRefStrings"]
+test = ["Test", "OffsetArrays"]

src/StructArrays.jl

@@ -14,11 +14,6 @@ include("collect.jl")
 include("sort.jl")
 include("groupjoin.jl")
 include("lazy.jl")
-using Tables, WeakRefStrings
 include("tables.jl")
-function refs(a::WeakRefStrings.StringArray{T}) where {T}
-    S = Union{WeakRefStrings.WeakRefString{UInt8}, typeintersect(T, Missing)}
-    convert(WeakRefStrings.StringArray{S}, a)
-end
 
 end # module

src/sort.jl

@@ -1,6 +1,11 @@
 using Base.Sort, Base.Order
+using WeakRefStrings: WeakRefString, StringArray
 
 refs(v::PooledArray) = v.refs
+function refs(a::StringArray{T}) where {T}
+    S = Union{WeakRefString{UInt8}, typeintersect(T, Missing)}
+    convert(StringArray{S}, a)
+end
 refs(v::AbstractArray) = v
 refs(v::StructArray) = StructArray(map(refs, fieldarrays(v)))
 

src/tables.jl

@@ -1,3 +1,5 @@
+using Tables: Tables
+
 Tables.istable(::Type{<:StructVector}) = true
 Tables.rowaccess(::Type{<:StructVector}) = true
 Tables.columnaccess(::Type{<:StructVector}) = true