Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect label for use in HTML #363

Open
3 of 5 tasks
aeneasr opened this issue Feb 26, 2025 · 2 comments
Open
3 of 5 tasks

Fix incorrect label for use in HTML #363

aeneasr opened this issue Feb 26, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@aeneasr
Copy link
Member

aeneasr commented Feb 26, 2025

Preflight checklist

Ory Network Project

No response

Describe the bug

Image

Reproducing the bug

Open a page with a label

Relevant log output

Relevant configuration

Version

master

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@aeneasr aeneasr added the bug Something isn't working label Feb 26, 2025
@jonas-jonas
Copy link
Member

The fix is to use the name as the id on the corresponding input as well.

@aeneasr
Copy link
Member Author

aeneasr commented Feb 26, 2025

You'll likely get duplicated IDs, and IDs don't generally work well when it's embedded as a library. I suggest a different solution, I think it can be done with proper HTML nesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants