Skip to content

Conversation

@ArnoSen
Copy link
Contributor

@ArnoSen ArnoSen commented Nov 28, 2025

The BuildImage select the Docker Engine version to use in the API request based on the build options selected. However there is no check that the selected API version is supported by the engine. This is now fixed.

Related Issue or Design Document

Fix for #620

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2025

CLA assistant check
All committers have signed the CLA.

@ArnoSen ArnoSen changed the title fix for selecting an unsupported api version in BuildImage fix BuildImage: prevent selecting an unsupported api version Nov 28, 2025
@ArnoSen ArnoSen changed the title fix BuildImage: prevent selecting an unsupported api version fix: prevent selecting an unsupported api version in BuildImage Nov 28, 2025
Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alnr alnr merged commit d1539a6 into ory:v3 Dec 5, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants