Skip to content

Commit 272e8a9

Browse files
committed
Merge remote-tracking branch 'private/public/master' into dev
* private/public/master: BAP-7696: Update jsTree library Updated submodule references: BAP-9554: Web installer fails when DB does not exist BAP-7171: Implement assets version for our JS files BAP-8029: Installer doesn't support filesystem with file name length different from 255 CRM-4725 Update jshint and jscs to allow comments be longer than 120 symbols Fixed repository links. CRM-4624: Fix cross bundle less import in symlink assets mode Updated submodule references:
2 parents c51b474 + d6dea74 commit 272e8a9

13 files changed

+41
-17
lines changed

.jscsrc

+6-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@
77
"**/*.min.js"
88
],
99
"validateIndentation": 4,
10-
"maximumLineLength": 120,
10+
"maximumLineLength": {
11+
"value": 120,
12+
"tabSize": 4,
13+
"allowComments": true,
14+
"allowRegex": true
15+
},
1116
"requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties",
1217
"disallowSpaceAfterObjectKeys": true,
1318
"requireSpaceBeforeObjectValues": true,

.jshintrc

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"maxdepth": 5,
1919
"maxstatements": 35,
2020
"quotmark": "single",
21-
"maxlen": 120,
2221
"browser": true,
2322
"white": true,
2423

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ http://getcomposer.org/ or just run the following command:
3838
curl -s https://getcomposer.org/installer | php
3939
```
4040

41-
- Clone https://github.com/orocrm/orocommerce-application.git repository with
41+
- Clone https://github.com/orocommerce/orocommerce-application.git repository with
4242

4343
```bash
44-
git clone --recursive https://github.com/orocrm/orocommerce-application.git
44+
git clone --recursive https://github.com/orocommerce/orocommerce-application.git
4545
```
4646

4747
- Make sure that you have [NodeJS][2] installed

app/OroRequirements.php

+6-3
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,11 @@ class_exists('COM'),
9696
if (!defined('PHP_WINDOWS_VERSION_BUILD')) {
9797
$this->addRequirement(
9898
$this->checkFileNameLength(),
99-
'Cache folder should not be inside encrypted directory',
100-
'Move <strong>app/cache</strong> folder outside encrypted directory.'
99+
'Maximum supported filename length must be greater or equal 242 characters.' .
100+
' Make sure that the cache folder is not inside the encrypted directory.',
101+
'Move <strong>app/cache</strong> folder outside encrypted directory.',
102+
'Maximum supported filename length must be greater or equal 242 characters.' .
103+
' Move app/cache folder outside encrypted directory.'
101104
);
102105
}
103106

@@ -353,7 +356,7 @@ protected function checkFileNameLength()
353356

354357
$fileLength = trim($getConf->getOutput());
355358

356-
return $fileLength == 255;
359+
return $fileLength >= 242;
357360
}
358361

359362
/**

app/Resources/translations/install.en.yml

+2
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,5 @@ process:
2727
button:
2828
next: Next
2929
refresh: Refresh
30+
31+
wait_for_warming_up_cache: Waiting for warming up application cache

app/config/config.yml

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ assetic:
4848
lessphp:
4949
file: %kernel.root_dir%/../vendor/leafo/lessphp/lessc.inc.php
5050
apply_to: "\.less$"
51+
paths: ["%kernel.root_dir%/../web/bundles"]
5152
cssmin:
5253
file: %kernel.root_dir%/Resources/php/cssmin-v3.0.1.php
5354

app/config/parameters.yml.dist

+4
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,7 @@ parameters:
3030
secret: ThisTokenIsNotSoSecretChangeIt
3131
installed: ~
3232
assets_version: ~
33+
assets_version_strategy: time_hash # A strategy should be used to generate the global assets version, can be:
34+
# null - the assets version stays unchanged
35+
# time_hash - a hash of the current time
36+
# incremental - the next assets version is the previous version is incremented by one (e.g. 'ver1' -> 'ver2' or '1' -> '2')

app/config/parameters_test.yml.dist

+1
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ parameters:
3030
secret: ThisTokenIsNotSoSecretChangeIt
3131
installed: ~
3232
assets_version: ~
33+
assets_version_strategy: time_hash
3334

composer.json

+6-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@
7474
"components/font-awesome": "~4.3.0",
7575
"piwik/device-detector": "~3.0",
7676
"oro/jsplumb": "~1.7",
77-
"oro/moment-timezone": "0.3.*"
77+
"oro/moment-timezone": "0.3.*",
78+
"vakata/jstree": "^3.2"
7879
},
7980
"require-dev": {
8081
"sensio/generator-bundle": "2.5.3"
@@ -88,14 +89,16 @@
8889
"Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
8990
"Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
9091
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::setPermissions",
91-
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::installAssets"
92+
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::installAssets",
93+
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::setAssetsVersion"
9294
],
9395
"post-update-cmd": [
9496
"Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",
9597
"Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
9698
"Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
9799
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::setPermissions",
98-
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::installAssets"
100+
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::installAssets",
101+
"Oro\\Bundle\\InstallerBundle\\Composer\\ScriptHandler::setAssetsVersion"
99102
]
100103
},
101104
"minimum-stability": "dev",

src/Oro

Submodule Oro updated from 16b8a20 to 86620be

src/OroB2B

web/install.php

+10-4
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
$data = Yaml::parse($paramFile);
2020

2121
if (is_array($data)
22-
&& isset($data['parameters'])
2322
&& isset($data['parameters']['installed'])
24-
&& false != $data['parameters']['installed']
23+
&& $data['parameters']['installed']
2524
) {
2625
require_once __DIR__ . '/../app/DistributionKernel.php';
2726

@@ -90,7 +89,13 @@ function iterateRequirements(array $collection)
9089
$(function() {
9190
<?php if (!count($majorProblems)) : ?>
9291
// initiate application in background
93-
$.get('installer/flow/oro_installer/configure');
92+
$('#status')
93+
.text(<?php echo json_encode($translator->trans('process.wait_for_warming_up_cache')); ?>)
94+
.prepend($('<span class="icon-wait"></span>'))
95+
$.get('installer/flow/oro_installer/configure').always(function() {
96+
$('#status').empty();
97+
$('#next-button').addClass('primary').removeClass('disabled');
98+
});
9499
<?php endif; ?>
95100
});
96101
</script>
@@ -186,13 +191,14 @@ function iterateRequirements(array $collection)
186191
<?php endforeach; ?>
187192
</div>
188193
<div class="button-set">
194+
<div id="status" class="status-box"></div>
189195
<div class="pull-right">
190196
<?php if (count($majorProblems) || count($minorProblems)): ?>
191197
<a href="install.php" class="button icon-reset">
192198
<span><?php echo $translator->trans('process.button.refresh'); ?></span>
193199
</a>
194200
<?php endif; ?>
195-
<a href="<?php echo count($majorProblems) ? 'javascript: void(0);' : 'app.php/installer'; ?>" class="button next <?php echo count($majorProblems) ? 'disabled' : 'primary'; ?>">
201+
<a id="next-button" href="<?php echo count($majorProblems) ? 'javascript: void(0);' : 'app.php/installer'; ?>" class="button next disabled">
196202
<span><?php echo $translator->trans('process.button.next'); ?></span>
197203
</a>
198204
</div>

0 commit comments

Comments
 (0)