You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm working on updating the ADC module to use the new esp_adc component and to avoid deprecation warnings. I'm doing this mainly to fix an issue with the ULP RISCV, where there is a driver conflict because in order to initiate the adc for the ULP, we need to use a function that is a part of the new adc driver. I've mentioned this in my PR #16469 but I got everything working.
The ULP also needs to have RTC pins setup if you plan on using output with the ULP by first calling esp-idf rtc_gpio... functions.
Will it be better to add functions like adc_setup() and rtc_pin_out() to the ULP module, or should I extend the ADC and Pin modules respectively?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm working on updating the ADC module to use the new esp_adc component and to avoid deprecation warnings. I'm doing this mainly to fix an issue with the ULP RISCV, where there is a driver conflict because in order to initiate the adc for the ULP, we need to use a function that is a part of the new adc driver. I've mentioned this in my PR #16469 but I got everything working.
The ULP also needs to have RTC pins setup if you plan on using output with the ULP by first calling esp-idf
rtc_gpio...
functions.Will it be better to add functions like
adc_setup()
andrtc_pin_out()
to the ULP module, or should I extend the ADC and Pin modules respectively?Beta Was this translation helpful? Give feedback.
All reactions