chore: some minor cleanups (wjakob#4)

* docs: fix spelling

* chore: clean up some minor stylistic issues

* fix: always include build-backend when using pyproject.toml

* Update tests/test_classes.py

Author: henryiii

include/nanobind/nb_class.h

@@ -23,25 +23,25 @@ enum class type_flags : uint32_t {
     /// Is this a python type that extends a bound C++ type?
     is_python_type           = (1 << 4),
 
-    /// Is the 'scope' field of the type_data struture set?
+    /// Is the 'scope' field of the type_data structure set?
     has_scope                = (1 << 5),
 
-    /// Is the 'doc' field of the type_data struture set?
+    /// Is the 'doc' field of the type_data structure set?
     has_doc                  = (1 << 6),
 
-    /// Is the 'base' field of the type_data struture set?
+    /// Is the 'base' field of the type_data structure set?
     has_base                 = (1 << 7),
 
-    /// Is the 'base_py' field of the type_data struture set?
+    /// Is the 'base_py' field of the type_data structure set?
     has_base_py              = (1 << 8),
 
-    /// Is the 'destruct' field of the type_data struture set?
+    /// Is the 'destruct' field of the type_data structure set?
     has_destruct             = (1 << 9),
 
-    /// Is the 'copy' field of the type_data struture set?
+    /// Is the 'copy' field of the type_data structure set?
     has_copy                 = (1 << 10),
 
-    /// Is the 'move' field of the type_data struture set?
+    /// Is the 'move' field of the type_data structure set?
     has_move                 = (1 << 11),
 
     /// Internal: does the type maintain a list of implicit conversions?

pyproject.toml

@@ -1,5 +1,7 @@
 [build-system]
 requires = ["setuptools>=42", "wheel", "scikit-build", "cmake>=3.17", "ninja"]
+build-backend = "setuptools.build_meta"
+
 
 [tool.pytest.ini_options]
 testpaths = [ "tests" ]

setup.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from setuptools import setup
 import re
 import os
@@ -13,8 +11,8 @@
     matches = dict(VERSION_REGEX.findall(f.read()))
     nanobind_version = "{MAJOR}.{MINOR}.{PATCH}".format(**matches)
 
-long_description = \
-'''_nanobind_ is a small binding library that exposes C++ types in Python and
+long_description = '''\
+_nanobind_ is a small binding library that exposes C++ types in Python and
 vice versa. It is reminiscent of
 _[Boost.Python](https://www.boost.org/doc/libs/1_64_0/libs/python/doc/html)_
 and _[pybind11](http://github.com/pybind/pybind11)_ and uses near-identical
@@ -28,7 +26,7 @@
     try:
         os.symlink(os.path.join(dirname, name),
                    os.path.join(dirname, 'src', 'nanobind', name))
-    except FileExistsError: 
+    except FileExistsError:
         pass
 
 setup(

src/nb_func.cpp

@@ -730,7 +730,7 @@ static PyObject *nb_func_vectorcall_simple(PyObject *self,
 static PyObject *nb_meth_descr_get(PyObject *self, PyObject *inst, PyObject *) {
     if (inst) {
         /* Return a classic bound method. This should be avoidable
-           in most cases via the 'CALL_METHOD' opcode and vector calls. PyTest
+           in most cases via the 'CALL_METHOD' opcode and vector calls. Pytest
            rewrites the bytecode in a way that breaks this optimization :-/ */
         return PyMethod_New(self, inst);
     } else {

tests/test_classes.py

@@ -129,7 +129,7 @@ def test06_reference_internal(clean):
 
 def test07_big():
     x = [t.Big() for i in range(1024)]
-    x = [t.BigAligned() for i in range(1024)]
+    x2 = [t.BigAligned() for i in range(1024)]
 
 
 def test08_inheritance():
@@ -151,20 +151,20 @@ def test09_method_vectorcall():
     def f(a, b, c, d, e):
         out.append((a, b, c, d, e))
 
-    class my_class:
+    class MyClass:
         def f(self, a, b, c, d, e):
             self.out = ((a, b, c, d, e))
 
     t.call_function(f)
 
-    i = my_class()
+    i = MyClass()
     t.call_method(i)
     assert out == [(1, 2, "hello", True, 4)]
     assert i.out == (1, 2, "hello", True, 4)
 
 
 def test10_trampoline(clean):
-    for i in range(10):
+    for _ in range(10):
         class Dachshund(t.Animal):
             def __init__(self):
                 super().__init__()
@@ -174,7 +174,7 @@ def what(self):
                 return "yap"
 
         d = Dachshund()
-        for i in range(10):
+        for _ in range(10):
             assert t.go(d) == 'Dachshund says yap'
 
     a = 0

tests/test_enum.py

@@ -1,6 +1,5 @@
 import test_enum_ext as t
 import pytest
-import gc
 
 def test01_unsigned_enum():
     assert repr(t.Enum.A) == 'Enum.A'

tests/test_functions.py

@@ -3,7 +3,7 @@
 
 def test01_capture():
     # Functions with and without capture object of different sizes
-    assert t.test_01() == None
+    assert t.test_01() is None
     assert t.test_02(5, 3) == 2
     assert t.test_03(5, 3) == 44
     assert t.test_04() == 60
@@ -127,7 +127,7 @@ def test13_call_guard():
     assert t.call_guard_value() == 0
     assert t.test_call_guard() == 1
     assert t.call_guard_value() == 2
-    assert t.test_release_gil() == False
+    assert not t.test_release_gil()
 
 def test14_print(capsys):
     t.test_print()

tests/test_holders.py

@@ -139,7 +139,7 @@ def test07_uniqueptr_passthrough(clean):
     t.reset()
 
     with pytest.warns(RuntimeWarning, match=r'nanobind::detail::nb_relinquish_ownership()'):
-        with pytest.raises(TypeError) as excinfo:
+        with pytest.raises(TypeError):
             assert t.passthrough_unique(t.Example(1)).value == 1
     assert t.passthrough_unique_2(t.Example(1)).value == 1
     assert t.stats() == (2, 2)