Optimization: the connect descriptor sent to the database does not

include the RETRY_DELAY parameter unless the RETRY_COUNT parameter is
also specified.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -40,6 +40,9 @@ Thin Mode Changes
 #)  Error ``DPY-3001: bequeath is only supported in python-oracledb thick
     mode`` is now raised when attempting to connect to the database without a
     connect string.
+#)  Optimization: the connect descriptor sent to the database does not include
+    the RETRY_DELAY parameter unless the RETRY_COUNT parameter is also
+    specified.
 #)  Internal change: improve low-level encoding and decoding routines.
 #)  Internal change: send buffer length for bind variables without unneeded
     adjustment.

src/oracledb/impl/base/connect_params.pyx

@@ -785,8 +785,8 @@ cdef class Description(ConnectParamsNode):
             parts.append("(SOURCE_ROUTE=ON)")
         if self.retry_count != 0:
             parts.append(f"(RETRY_COUNT={self.retry_count})")
-        if self.retry_delay != 0:
-            parts.append(f"(RETRY_DELAY={self.retry_delay})")
+            if self.retry_delay != 0:
+                parts.append(f"(RETRY_DELAY={self.retry_delay})")
         if self.expire_time != 0:
             parts.append(f"(EXPIRE_TIME={self.expire_time})")
         if self.tcp_connect_timeout != DEFAULT_TCP_CONNECT_TIMEOUT:

tests/test_4500_connect_params.py

@@ -898,8 +898,7 @@ def test_4549(self):
         self.assertEqual(params.port, [1521, 4549, 4549, 1521])
         self.assertEqual(params.service_name, "service_name_4549")
         expected_conn_string = (
-            "(DESCRIPTION=(RETRY_DELAY=1)"
-            "(ADDRESS=(PROTOCOL=tcp)(HOST=host4549a)(PORT=1521))"
+            "(DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=host4549a)(PORT=1521))"
             "(ADDRESS_LIST=(ADDRESS=(PROTOCOL=tcp)(HOST=host4549b)(PORT=4549))"
             "(ADDRESS=(PROTOCOL=tcp)(HOST=host4549c)(PORT=4549)))"
             "(ADDRESS=(PROTOCOL=tcp)(HOST=host4549d)(PORT=1521))"